Log the route not found exception on a lower level #21993

rullzer · 2020-07-24T13:43:20Z

This should be logged but it is not that critical to wanner level 3

Signed-off-by: Roeland Jago Douma [email protected]

This should be logged but it is not that critical to wanner level 3 Signed-off-by: Roeland Jago Douma <[email protected]>

kesselb · 2020-07-24T14:25:49Z

Should fix #20572 (by not logging the error anymore)* but #14266 (comment) is still happening.

* to validate send a OPTIONS request to remote.php

faily-bot · 2020-07-24T14:51:55Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31089: failure

mariadb10.1-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #171 ('folder', 13, 11)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

mysql8.0-php7.2

Show full log

There was 1 error:

1) Test\Comments\ManagerTest::testGetNumberOfUnreadCommentsForFolder
InvalidArgumentException: Object parameters must be string and not empty

/drone/src/lib/private/Comments/Manager.php:208
/drone/src/lib/private/Comments/Manager.php:941
/drone/src/tests/lib/Comments/ManagerTest.php:346

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

integration-auth

build/integration/features/auth.feature:70

Show full log

  Scenario: using OCS anonymously                                                    # /drone/src/build/integration/features/auth.feature:70
[Fri Jul 24 13:57:04 2020] 127.0.0.1:36450 [404]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 13:57:05 2020] 127.0.0.1:36470 [200]: /ocs/v1.php/cloud/users
[Fri Jul 24 13:57:05 2020] 127.0.0.1:36494 [200]: /ocs/v1.php/cloud/users/user0
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36512 [200]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36530 [200]: /login
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36536 [303]: /login
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36562 [200]: /index.php/apps/files/
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36566 [200]: /index.php/settings/personal/authtokens
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36572 [200]: /index.php/settings/personal/authtokens/56
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36574 [303]: /login
[Fri Jul 24 13:57:06 2020] 127.0.0.1:36578 [200]: /index.php/apps/files/
[Fri Jul 24 13:57:07 2020] 127.0.0.1:36582 [303]: /login
[Fri Jul 24 13:57:07 2020] 127.0.0.1:36602 [200]: /index.php/apps/files/
[Fri Jul 24 13:57:07 2020] 127.0.0.1:36608 [200]: /index.php/settings/personal/authtokens
[Fri Jul 24 13:57:07 2020] TypeError: Argument 11 passed to OCA\Files_Sharing\External\Manager::__construct() must be of the type string, null given, called in /drone/src/apps/files_sharing/lib/AppInfo/Application.php on line 98 at /drone/src/apps/files_sharing/lib/External/Manager.php#91
[Fri Jul 24 13:57:07 2020] 127.0.0.1:36614 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares
    When requesting "/ocs/v1.php/apps/files_sharing/api/v1/remote_shares" with "GET" # FeatureContext::requestingWith()
    Then the OCS status code should be "997"                                         # FeatureContext::theOCSStatusCodeShouldBe()
      Notice: Trying to get property 'meta' of non-object in /drone/src/build/integration/features/bootstrap/BasicStructure.php line 153
[Fri Jul 24 13:57:07 2020] 127.0.0.1:36616 [200]: /ocs/v1.php/cloud/users/user0
[Fri Jul 24 13:57:08 2020] 127.0.0.1:36644 [404]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 13:57:08 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Jul 24 13:57:08 2020] 127.0.0.1:36658 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Jul 24 13:57:08 2020] 127.0.0.1:36664 [207]: /remote.php/dav/systemtags/
[Fri Jul 24 13:57:08 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Jul 24 13:57:08 2020] 127.0.0.1:36682 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Jul 24 13:57:08 2020] 127.0.0.1:36684 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Jul 24 13:57:09 2020] 127.0.0.1:36706 [404]: /remote.php/dav/calendars/admin/MyCalendar

acceptance-header

tests/acceptance/features/header.feature:31

Show full log

  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
      Failed asserting that true is false.
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

simonspa · 2020-10-25T08:06:09Z

/backport 19

simonspa · 2020-10-25T08:06:51Z

@rullzer could this be backported to stable19 too?

nickvergessen · 2020-10-25T09:00:40Z

/backport to stable19

florom · 2021-04-12T08:36:47Z

Hi Devs,

I encountered this issue again with
21.0.1
php 7.3.latest
mariadb 10.latest

Probably something is wrong (again)

Inf

Info | no app in context |

Symfony\Component\Routing\Exception\RouteNotFoundException: Unable to generate a URL for the named route "phonetrack.page.index" as such route does not exist.

/var/www/nextcloud/lib/private/Route/Router.php - line 365:

Symfony\Component\Routing\Generator\UrlGenerator->generate("phonetrack.page.index", [], 1)

/var/www/nextcloud/lib/private/Route/CachingRouter.php - line 60:

OC\Route\Router->generate("phonetrack.page.index", [], false)

/var/www/nextcloud/lib/private/URLGenerator.php - line 85:

OC\Route\CachingRouter->generate("phonetrack.page.index", [])

/var/www/nextcloud/apps/phonetrack/lib/AppInfo/Application.php - line 58:

OC\URLGenerator->linkToRoute("phonetrack.page.index")

/var/www/nextcloud/lib/private/NavigationManager.php - line 110:

OCA\PhoneTrack\AppInfo\Application->OCA\PhoneTrack\AppInfo{closure}("*** sensiti ... *")

/var/www/nextcloud/apps/theming/lib/ThemingDefaults.php - line 184:

OC\NavigationManager->getAll("guest")

/var/www/nextcloud/lib/private/legacy/OC_Defaults.php - line 263:

OCA\Theming\ThemingDefaults->getShortFooter()

/var/www/nextcloud/lib/public/Defaults.php - line 169:

OC_Defaults->getLongFooter()

/var/www/nextcloud/core/templates/layout.guest.php - line 55:

OCP\Defaults->getLongFooter()

/var/www/nextcloud/lib/private/Template/Base.php - line 178:

include("/var/www/ne ... p")

/var/www/nextcloud/lib/private/Template/Base.php - line 150:

OC\Template\Base->load("/var/www/ne ... p", null)

/var/www/nextcloud/lib/private/legacy/OC_Template.php - line 180:

OC\Template\Base->fetchPage(null)

/var/www/nextcloud/lib/private/legacy/OC_Template.php - line 211:

OC_Template->fetchPage(null)

/var/www/nextcloud/lib/private/Template/Base.php - line 132:

OC_Template->fetchPage()

/var/www/nextcloud/lib/private/legacy/OC_Template.php - line 332:

OC\Template\Base->printPage()

/var/www/nextcloud/index.php - line 63:

OC_Template::printExceptionErrorPage(Exception {}, 500)

-- | -- | -- |

2021-04-12T09:47:57+0200

Thank you.

EDIT:

Other user mentioned it in this thread:
https://help.nextcloud.com/t/nextcloud-break-after-update-to-version-21/113395

Log the route not found exception on a lower level

b57019b

This should be logged but it is not that critical to wanner level 3 Signed-off-by: Roeland Jago Douma <[email protected]>

rullzer added enhancement 3. to review Waiting for reviews labels Jul 24, 2020

rullzer added this to the Nextcloud 20 milestone Jul 24, 2020

rullzer requested review from ArtificialOwl, MorrisJobke, juliusknorr and nickvergessen July 24, 2020 13:43

MorrisJobke approved these changes Jul 24, 2020

View reviewed changes

nickvergessen approved these changes Jul 30, 2020

View reviewed changes

nickvergessen merged commit a32e6a7 into master Jul 30, 2020

nickvergessen deleted the fix/lower_route_not_found_level branch July 30, 2020 08:59

MorrisJobke mentioned this pull request Jul 30, 2020

Symfony\Component\Routing\Exception\RouteNotFoundException: Unable to generate a URL for the named route "xyz.xyz.index" as such route does not exist. #20572

Closed

backportbot-nextcloud bot added the backport-request label Oct 25, 2020

backportbot-nextcloud bot mentioned this pull request Oct 25, 2020

[stable19] Log the route not found exception on a lower level #23676

Merged

backportbot-nextcloud bot removed the backport-request label Oct 25, 2020

brianjmurrell mentioned this pull request Mar 19, 2022

[Bug]: Symfony\Component\Routing\Exception\RouteNotFoundException: Unable to generate a URL for the named route "xyz.xyz.index" as such route does not exist. #31631

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Log the route not found exception on a lower level #21993

Log the route not found exception on a lower level #21993

Uh oh!

rullzer commented Jul 24, 2020

Uh oh!

kesselb commented Jul 24, 2020 •

edited

Loading

Uh oh!

faily-bot bot commented Jul 24, 2020

Uh oh!

simonspa commented Oct 25, 2020

Uh oh!

simonspa commented Oct 25, 2020

Uh oh!

nickvergessen commented Oct 25, 2020

Uh oh!

florom commented Apr 12, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Log the route not found exception on a lower level #21993

Log the route not found exception on a lower level #21993

Uh oh!

Conversation

rullzer commented Jul 24, 2020

Uh oh!

kesselb commented Jul 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

faily-bot bot commented Jul 24, 2020

Status of 31089: failure

mariadb10.1-php7.2

mysql8.0-php7.2

integration-auth

acceptance-header

Uh oh!

simonspa commented Oct 25, 2020

Uh oh!

simonspa commented Oct 25, 2020

Uh oh!

nickvergessen commented Oct 25, 2020

Uh oh!

florom commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kesselb commented Jul 24, 2020 •

edited

Loading

florom commented Apr 12, 2021 •

edited

Loading