-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Password policy validation fail for new users #22028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tch the event; if even is null use fallback Signed-off-by: Murielle Lerch <[email protected]>
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
| $passwordEvent->getPassword(); | ||
| if(isset($passwordEvent)){ | ||
| $password .= $passwordEvent->getPassword(); | ||
| } else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ($password === null) {
// fallback logic for password
}
If $password is null the password_policy (or any other listener to GenerateSecurePasswordEvent) is not enabled hence we can use a simpler fallback but using a strong password by default is probably not wrong.
|
I added your suggested modifications. Unfortunately, I am a newbie and tried to fix the "php-cs check" failure. |
310f1d2 to
94e54e5
Compare
…word is null for fallback Signed-off-by: Murielle Lerch <[email protected]>
Password policy validation fail for new users #22014
Other option for fallback:
/apps/provisioning_api/lib/Controller/UsersController.php(around line324)