Skip to content

Enable user_status by default #22076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Aug 3, 2020
Merged

Enable user_status by default #22076

nickvergessen merged 1 commit into from
Aug 3, 2020

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Jul 31, 2020

Follow up for #21186

@georgehrke georgehrke added the 3. to review Waiting for reviews label Jul 31, 2020
jancborchardt
jancborchardt approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuss please

@jancborchardt jancborchardt added this to the Nextcloud 20 milestone Jul 31, 2020
nickvergessen
nickvergessen reviewed Jul 31, 2020
View reviewed changes
nickvergessen
nickvergessen reviewed Jul 31, 2020
View reviewed changes
@georgehrke georgehrke force-pushed the feature/noid/default_enable_user_status branch from 3799682 to a8c4a83 Compare August 3, 2020 06:39
@faily-bot
Copy link

faily-bot bot commented Aug 3, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31296: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log 
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@nickvergessen nickvergessen merged commit 7b91cb5 into master Aug 3, 2020
@nickvergessen nickvergessen deleted the feature/noid/default_enable_user_status branch August 3, 2020 07:44
@nickvergessen nickvergessen mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: status

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

5 participants

@georgehrke @nickvergessen @jancborchardt @juliusknorr