Skip to content

Delete chunks if the move on an upload failed #22128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Aug 13, 2020
Merged

Delete chunks if the move on an upload failed #22128

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
860f6d8
Delete chunks if the move on an upload failed
juliusknorr Aug 6, 2020
cda5cfc
Adjust chunking test for non-existing target node
juliusknorr Aug 12, 2020
6722246
Return proper status when file didn't exist before
juliusknorr Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust chunking test for non-existing target node 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Aug 12, 2020
commit cda5cfc01ea93244dbb1ea93a207d0933b6ba6db
10 changes: 7 additions & 3 deletions apps/dav/tests/unit/Upload/ChunkingPluginTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,18 @@ public function testBeforeMoveFutureFileSkipNonExisting() {
->method('nodeExists')
->with('target')
->willReturn(false);
$this->response->expects($this->never())
->method('setStatus');
$this->response->expects($this->once())
->method('setHeader')
->with('Content-Length', '0');
$this->response->expects($this->once())
->method('setStatus')
->with(204);
$this->request->expects($this->once())
->method('getHeader')
->with('OC-Total-Length')
->willReturn(4);

$this->assertNull($this->plugin->beforeMove('source', 'target'));
$this->assertFalse($this->plugin->beforeMove('source', 'target'));
}

public function testBeforeMoveFutureFileMoveIt() {
Expand Down