Skip to content

[stable19] Silence duplicate session warnings #22247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Aug 14, 2020
Merged

[stable19] Silence duplicate session warnings #22247

MorrisJobke merged 1 commit into from
Aug 14, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 14, 2020

backport of #22243

@rullzer @backportbot
Silence duplicate session warnings
a6760c2 
Fixes #20490

Basically restroring the old behavior.

Signed-off-by: Roeland Jago Douma <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.2 milestone Aug 14, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 14, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31789: failure

integration-provisioning-v2

  • build/integration/features/provisioning-v2.feature:22
Show full log 
  Scenario: Searching by displayname in groups                                                    # /drone/src/build/integration/features/provisioning-v2.feature:22
    Given As an "admin"                                                                           # FeatureContext::asAn()
[Fri Aug 14 07:43:52 2020] 127.0.0.1:49368 [404]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 07:43:53 2020] 127.0.0.1:49392 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 07:43:53 2020] 127.0.0.1:49470 [200]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 07:43:53 2020] 127.0.0.1:49514 [200]: /ocs/v2.php/cloud/users/user-in-group
    And user "user-in-group" with displayname "specific-name" exists                              # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 07:43:53 2020] 127.0.0.1:49538 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 07:43:54 2020] 127.0.0.1:49558 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 07:43:54 2020] 127.0.0.1:49628 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 07:43:55 2020] 127.0.0.1:49668 [200]: /ocs/v2.php/cloud/users/user-in-group2
    And user "user-in-group2" with displayname "another-name" exists                              # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 07:43:55 2020] 127.0.0.1:49688 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 07:43:55 2020] 127.0.0.1:49706 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 07:43:56 2020] 127.0.0.1:49782 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 07:43:56 2020] 127.0.0.1:49818 [200]: /ocs/v2.php/cloud/users/user-not-in-group
    And user "user-not-in-group" with displayname "specific-name" exists                          # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 07:43:56 2020] 127.0.0.1:49848 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 07:43:57 2020] 127.0.0.1:49874 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 07:43:57 2020] 127.0.0.1:49950 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 07:43:57 2020] 127.0.0.1:49982 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
    And user "user-not-in-group2" with displayname "another-name" exists                          # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 07:43:58 2020] 127.0.0.1:50010 [404]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 07:43:58 2020] 127.0.0.1:50046 [200]: /ocs/v2.php/cloud/groups
[Fri Aug 14 07:43:58 2020] 127.0.0.1:50074 [200]: /ocs/v2.php/cloud/groups/group-search
    And group "group-search" exists                                                               # FeatureContext::assureGroupExists()
[Fri Aug 14 07:43:58 2020] 127.0.0.1:50102 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Fri Aug 14 07:43:59 2020] 127.0.0.1:50126 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Fri Aug 14 07:43:59 2020] 127.0.0.1:50148 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
    And user "user-in-group" belongs to group "group-search"                                      # FeatureContext::assureUserBelongsToGroup()
[Fri Aug 14 07:43:59 2020] 127.0.0.1:50180 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Fri Aug 14 07:43:59 2020] 127.0.0.1:50206 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Fri Aug 14 07:44:00 2020] 127.0.0.1:50230 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
    And user "user-in-group2" belongs to group "group-search"                                     # FeatureContext::assureUserBelongsToGroup()
[Fri Aug 14 07:44:00 2020] 127.0.0.1:50256 [200]: /ocs/v2.php/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi
    When sending "GET" to "/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi" # FeatureContext::sendingTo()
    Then the OCS status code should be "200"                                                      # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                      # FeatureContext::theHTTPStatusCodeShouldBe()
    And detailed users returned are                                                               # FeatureContext::theDetailedUsersShouldBe()
      | user-in-group |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
       Array (
      -    0 => 'user-in-group'
[Fri Aug 14 07:44:00 2020] 127.0.0.1:50296 [200]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 07:44:00 2020] 127.0.0.1:50326 [404]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 07:44:01 2020] 127.0.0.1:50348 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 07:44:01 2020] 127.0.0.1:50380 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 07:44:01 2020] 127.0.0.1:50410 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 07:44:02 2020] 127.0.0.1:50442 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 07:44:02 2020] 127.0.0.1:50462 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 07:44:02 2020] 127.0.0.1:50502 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 07:44:02 2020] 127.0.0.1:50528 [200]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 07:44:03 2020] 127.0.0.1:50554 [404]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 07:44:03 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Aug 14 07:44:03 2020] 127.0.0.1:50580 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Aug 14 07:44:03 2020] 127.0.0.1:50590 [207]: /remote.php/dav/systemtags/
[Fri Aug 14 07:44:03 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Aug 14 07:44:03 2020] 127.0.0.1:50612 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Aug 14 07:44:03 2020] 127.0.0.1:50624 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Aug 14 07:44:03 2020] 127.0.0.1:50654 [404]: /remote.php/dav/calendars/admin/MyCalendar

@MorrisJobke MorrisJobke merged commit 7fffe82 into stable19 Aug 14, 2020
@MorrisJobke MorrisJobke deleted the backport/22243/stable19 branch August 14, 2020 08:00
@rullzer rullzer mentioned this pull request Aug 18, 2020
Merged
1 task
@korelstar korelstar mentioned this pull request Aug 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 19.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @MorrisJobke