Skip to content

Conversation

@MorrisJobke
Copy link
Member

cc @wobben

$rows[] = ['user directories', $userDirectoryCount];

$disabledUsers = $this->config->getUsersForUserValue('core', 'enabled', 'false');
$disabledUsersCount = count($disabledUsers);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 should maybe add a dedicated function for this instead. But I geuss disabled users shouldn't be too many :-X

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦈

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 19, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 19, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31956: failure

mariadb10.4-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #61 ('folder', 7, 19)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #10 (OC\Files\Search\SearchBinaryOperator Object (...), array(0, 1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
-    1 => 444
+    0 => '443'
+    1 => '444'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

@rullzer rullzer merged commit bc2b422 into master Aug 19, 2020
@rullzer rullzer deleted the enh/noid/show-disabled-user-count-in-userreport branch August 19, 2020 09:23
@rullzer
Copy link
Member

rullzer commented Aug 19, 2020

@MorrisJobke backport?

@MorrisJobke
Copy link
Member Author

/backport to stable19

@MorrisJobke
Copy link
Member Author

/backport to stable18

@blizzz
Copy link
Member

blizzz commented Aug 31, 2020

/backport to stable17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants