Skip to content

[stable19] Fix clicks on actions menu of non opaque file rows in acceptance tests #22503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Aug 31, 2020
Merged

[stable19] Fix clicks on actions menu of non opaque file rows in acceptance tests #22503

rullzer merged 1 commit into from
Aug 31, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 30, 2020

backport of #22481

@danxuliu @backportbot
Fix clicks on actions menu of non opaque file rows in acceptance tests
41c8b1b 
When a row is added to the file list the opacity of the file row is
animated from transparent to fully opaque. As the file actions menu is a
descendant of the row but overflows it when the row is not fully opaque
clicks on the menu entries "fall-through" and are received instead by
the rows behind.

The opacity animation is a CSS animation, and it is not possible to know
if a row is appearing or not except from its opacity (the row will have
the "appear" CSS class even after the animation ended). Therefore it
should be waited until the row of the file is fully opaque before using
the menu.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.3 milestone Aug 30, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 30, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32442: failure

postgres9-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log 
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

danxuliu
danxuliu approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/acceptance/features/app-files.feature:108 failure is unrelated.

@rullzer rullzer merged commit 4ef4239 into stable19 Aug 31, 2020
@rullzer rullzer deleted the backport/22481/stable19 branch August 31, 2020 07:49
@rullzer rullzer mentioned this pull request Sep 4, 2020
Merged
@MorrisJobke MorrisJobke mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu danxuliu approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 19.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @danxuliu