Skip to content

[stable18] Fix app password updating out of bounds #22570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Sep 4, 2020
Merged

[stable18] Fix app password updating out of bounds #22570

rullzer merged 1 commit into from
Sep 4, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 3, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22524

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.10 milestone Sep 3, 2020
ChristophWurst
ChristophWurst requested changes Sep 4, 2020
View reviewed changes
@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Sep 4, 2020
@rullzer rullzer mentioned this pull request Sep 4, 2020
Merged
@rullzer
Fix app password updating out of bounds
87a66c8 
When your password changes out of bounds your Nextcloud tokens will
become invalid. There is no real way around that. However we should make
sure that if you successfully log in again your passwords are all
updates

* Added event listener to the PostLoggedInEvent so that we can act on it
  - Only if it is not a token login
* Make sure that we actually reset the invalid state when we update a
  token. Else it keeps being marked invalid and thus not used.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the backport/22524/stable18 branch from d5be94b to 87a66c8 Compare September 4, 2020 07:18
@faily-bot
Copy link

faily-bot bot commented Sep 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32627: failure

sqlite

Show full log 
There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@rullzer rullzer merged commit ce93aaf into stable18 Sep 4, 2020
@rullzer rullzer deleted the backport/22524/stable18 branch September 4, 2020 10:26
@MorrisJobke MorrisJobke mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

1. to develop Accepted and waiting to be taken care of bug

Projects

None yet

Milestone

Nextcloud 18.0.9

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @ChristophWurst