Skip to content

[stable19] Use the correct root to determinate the webroot for the resource #22579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Sep 4, 2020
Merged

[stable19] Use the correct root to determinate the webroot for the resource #22579

rullzer merged 1 commit into from
Sep 4, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 4, 2020

backport of #22550

@nickvergessen @backportbot
Use the correct root to determinate the webroot for the resource
fc0cdbb 
Since all the compiled routes are based on the server webroot,
we have to use this, independent from which app this belongs to.

Signed-off-by: Joas Schilling <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added feature: caching Related to our caching system: scssCacher, jsCombiner... feature: scss labels Sep 4, 2020
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.3 milestone Sep 4, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Sep 4, 2020
@faily-bot
Copy link

faily-bot bot commented Sep 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32623: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testReuseExisting
Failed asserting that null is of type "string".

/drone/src/tests/lib/Files/Cache/ScannerTest.php:253

@rullzer rullzer mentioned this pull request Sep 4, 2020
Merged
@rullzer rullzer merged commit c1b971e into stable19 Sep 4, 2020
@rullzer rullzer deleted the backport/22550/stable19 branch September 4, 2020 10:35
@MorrisJobke MorrisJobke mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: caching Related to our caching system: scssCacher, jsCombiner... feature: scss

Projects

None yet

Milestone

Nextcloud 19.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @ChristophWurst @nickvergessen