Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Sep 7, 2020

First, this is not a compiled, but a static file.

Second, this is a very pragmatic approach. If someone prefers to wrap it in Webpack/Vue/$other magic, please close and take over, but ensure this is solved within Beta.

To reproduce:

  1. Enable an app that registers settings in 'additional' section, like impersonate
  2. Visit the settings
  3. Try to set something there – JS will error out, because escapeHTML function was removed

Apart of adding a custom escapeHTML function~~, the eslint warnings were fixed, too~~.

@blizzz blizzz added bug 3. to review Waiting for reviews labels Sep 7, 2020
@blizzz blizzz added this to the Nextcloud 20 milestone Sep 7, 2020
@blizzz blizzz force-pushed the fix/noid/depcreated-methods-settings branch from 6b76cb1 to 0f02760 Compare September 7, 2020 16:03
- solves non-working "additional settings" sections (at least)

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz force-pushed the fix/noid/depcreated-methods-settings branch from 0f02760 to 43ea48c Compare September 7, 2020 20:58
@faily-bot
Copy link

faily-bot bot commented Sep 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32775: failure

jsunit

Show full log
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'No OC found'
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (12.832 secs / 12.237 secs)

@rullzer rullzer mentioned this pull request Sep 8, 2020
13 tasks
@rullzer rullzer merged commit b4729ce into master Sep 8, 2020
@rullzer rullzer deleted the fix/noid/depcreated-methods-settings branch September 8, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants