Mitigate encoding issue with user principal uri #22770

georgehrke · 2020-09-10T10:59:22Z

To test this:

Create a user with a space in the username
Invite that user to an event in the calendar app

Master:

It fails with a 404, because it could not resolve the principal uri

This branch:

Inviting the user succeeds

Disclaimer:
The problem is bigger than this and requires a better fix in the long run. It is necessary, to have consistent, url-encoded principal uris everywhere.

georgehrke · 2020-09-10T10:59:39Z

@MorrisJobke @rullzer I would appreciate if we could backport this

georgehrke · 2020-09-10T11:01:21Z

@georgehrke force-pushed the bugfix/noid/urldecode_principal_uri branch from e91618a to fcddf8b now

Fixed a typo in the comment

faily-bot · 2020-09-10T13:56:48Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32951: failure

acceptance-access-levels

tests/acceptance/features/access-levels.feature:3
tests/acceptance/features/access-levels.feature:12
tests/acceptance/features/access-levels.feature:19

Show full log

  Scenario: regular users cannot see admin-level items in the Settings menu # /drone/src/tests/acceptance/features/access-levels.feature:3
    Given I am logged in                                                    # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I open the Settings menu                                           # SettingsMenuContext::iOpenTheSettingsMenu()
    Then I see that the Settings menu is shown                              # SettingsMenuContext::iSeeThatTheSettingsMenuIsShown()
    And I see that the "Settings" item in the Settings menu is shown        # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Users" item in the Settings menu is not shown       # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsNotShown()
    And I see that the "Help" item in the Settings menu is shown            # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Log out" item in the Settings menu is shown         # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()

  Scenario: regular users cannot see admin-level items on the Settings page  # /drone/src/tests/acceptance/features/access-levels.feature:12
    Given I am logged in                                                     # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I visit the settings page                                           # SettingsMenuContext::iVisitTheSettingsPage()
    Then I see that the "Personal info" entry in the settings panel is shown # SettingsMenuContext::iSeeThatTheItemEntryInTheSettingsPanelIsShown()
    And I see that the "Personal" settings panel is not shown                # SettingsMenuContext::iSeeThatTheItemSettingsPanelIsNotShown()
    And I see that the "Administration" settings panel is not shown          # SettingsMenuContext::iSeeThatTheItemSettingsPanelIsNotShown()

  Scenario: admin users can see admin-level items on the Settings page # /drone/src/tests/acceptance/features/access-levels.feature:19
    Given I am logged in as the admin                                  # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I visit the settings page                                     # SettingsMenuContext::iVisitTheSettingsPage()
    Then I see that the "Personal" settings panel is shown             # SettingsMenuContext::iSeeThatTheItemSettingsPanelIsShown()
    And I see that the "Administration" settings panel is shown        # SettingsMenuContext::iSeeThatTheItemSettingsPanelIsShown()

acceptance-app-files

tests/acceptance/features/app-files.feature:4
tests/acceptance/features/app-files.feature:11
tests/acceptance/features/app-files.feature:22
tests/acceptance/features/app-files.feature:108
tests/acceptance/features/app-files.feature:206
tests/acceptance/features/app-files.feature:215
tests/acceptance/features/app-files.feature:227
tests/acceptance/features/app-files.feature:246
tests/acceptance/features/app-files.feature:262
tests/acceptance/features/app-files.feature:281
tests/acceptance/features/app-files.feature:289

Show full log

  Scenario: open and close the details view        # /drone/src/tests/acceptance/features/app-files.feature:4
    Given I am logged in                           # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open        # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                   # FilesAppContext::iCloseTheDetailsView()
    Then I see that the details view is closed     # FilesAppContext::iSeeThatTheDetailsViewIsClosed()

  Scenario: open and close the details view twice  # /drone/src/tests/acceptance/features/app-files.feature:11
    Given I am logged in                           # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the details view for "welcome.txt"  # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open        # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                   # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed      # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    When I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open        # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                   # FilesAppContext::iCloseTheDetailsView()
    Then I see that the details view is closed     # FilesAppContext::iSeeThatTheDetailsViewIsClosed()

  Scenario: open and close the details view again after coming back from a different section # /drone/src/tests/acceptance/features/app-files.feature:22
    Given I am logged in                                                                     # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the details view for "welcome.txt"                                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                             # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I open the "Recent" section                                                          # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "Recent"                                           # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the details view for "welcome.txt"                                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                             # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    When I open the "All files" section                                                      # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "All files"                                        # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the details view for "welcome.txt"                                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                             # FilesAppContext::iCloseTheDetailsView()
    Then I see that the details view is closed                                               # FilesAppContext::iSeeThatTheDetailsViewIsClosed()

  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: copy a file in its same folder                                  # /drone/src/tests/acceptance/features/app-files.feature:206
    Given I am logged in                                                    # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I start the move or copy operation for "welcome.txt"               # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I copy to the last selected folder in the file picker               # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    Then I see that the file list contains a file named "welcome.txt"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "welcome (copy).txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: copy a file twice in its same folder                              # /drone/src/tests/acceptance/features/app-files.feature:215
    Given I am logged in                                                      # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I start the move or copy operation for "welcome.txt"                  # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I copy to the last selected folder in the file picker                 # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    When I start the move or copy operation for "welcome.txt"                 # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I copy to the last selected folder in the file picker                 # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    Then I see that the file list contains a file named "welcome.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "welcome (copy).txt"   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "welcome (copy 2).txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: copy a copy of a file in its same folder                          # /drone/src/tests/acceptance/features/app-files.feature:227
    Given I am logged in                                                      # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I start the move or copy operation for "welcome.txt"                  # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I copy to the last selected folder in the file picker                 # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    When I start the move or copy operation for "welcome (copy).txt"          # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I copy to the last selected folder in the file picker                 # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    Then I see that the file list contains a file named "welcome.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "welcome (copy).txt"   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "welcome (copy 2).txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: marking a file as favorite causes the file list to be sorted again                            # /drone/src/tests/acceptance/features/app-files.feature:246
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    When I mark "welcome.txt" as favorite                                                                 # FileListContext::iMarkAsFavorite()
    Then I see that "welcome.txt" is marked as favorite                                                   # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

  Scenario: mark a file as favorite in the details view               # /drone/src/tests/acceptance/features/app-files.feature:281
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the details view for "welcome.txt"                     # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                           # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    When I mark the file as favorite in the details view              # FilesAppContext::iMarkTheFileAsFavoriteInTheDetailsView()
    Then I see that "welcome.txt" is marked as favorite               # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that the file is marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView()

  Scenario: unmark a file as favorite in the details view                 # /drone/src/tests/acceptance/features/app-files.feature:289
    Given I am logged in                                                  # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the details view for "welcome.txt"                         # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I mark the file as favorite in the details view                   # FilesAppContext::iMarkTheFileAsFavoriteInTheDetailsView()
    And I see that "welcome.txt" is marked as favorite                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that the file is marked as favorite in the details view     # FilesAppContext::iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView()
    When I unmark the file as favorite in the details view                # FilesAppContext::iUnmarkTheFileAsFavoriteInTheDetailsView()
    Then I see that "welcome.txt" is not marked as favorite               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
    And I see that the file is not marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsNotMarkedAsFavoriteInTheDetailsView()

acceptance-app-files-sharing

tests/acceptance/features/app-files-sharing.feature:3
tests/acceptance/features/app-files-sharing.feature:23
tests/acceptance/features/app-files-sharing.feature:50
tests/acceptance/features/app-files-sharing.feature:68
tests/acceptance/features/app-files-sharing.feature:86
tests/acceptance/features/app-files-sharing.feature:113
tests/acceptance/features/app-files-sharing.feature:138
tests/acceptance/features/app-files-sharing.feature:158
tests/acceptance/features/app-files-sharing.feature:177
tests/acceptance/features/app-files-sharing.feature:197
tests/acceptance/features/app-files-sharing.feature:223
tests/acceptance/features/app-files-sharing.feature:249
tests/acceptance/features/app-files-sharing.feature:272
tests/acceptance/features/app-files-sharing.feature:298
tests/acceptance/features/app-files-sharing.feature:318
tests/acceptance/features/app-files-sharing.feature:338

Show full log

  Scenario: share a file with another user                                    # /drone/src/tests/acceptance/features/app-files-sharing.feature:3
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "farewell.txt" with "user0"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: share a file with another user that needs to accept shares        # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I visit the settings page                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section                                          # AppNavigationContext::iOpenTheSection()
    And I disable accepting the shares by default                             # SettingsContext::iDisableAcceptingTheSharesByDefault()
    And I see that shares are not accepted by default                         # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "farewell.txt" with "user0"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I accept the share for "/farewell.txt" in the notifications           # NotificationsContext::iAcceptTheShareForInTheNotifications()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: share a file with another user who already has a file with that name # /drone/src/tests/acceptance/features/app-files-sharing.feature:50
    Given I act as John                                                          # ActorContext::iActAs()
    And I am logged in as the admin                                              # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                            # ActorContext::iActAs()
    And I am logged in                                                           # LoginPageContext::iAmLoggedIn()
    And I act as John                                                            # ActorContext::iActAs()
    When I share "welcome.txt" with "user0"                                      # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                               # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                            # ActorContext::iActAs()
    And I open the Files app                                                     # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "welcome (2).txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "welcome (2).txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                      # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                             # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded    # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                         # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: share a skeleton file with another user before first login        # /drone/src/tests/acceptance/features/app-files-sharing.feature:68
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I share "welcome.txt" with "user0"                                   # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    Then I see that the file list contains a file named "welcome.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "welcome.txt"                             # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: reshare a file with another user                                  # /drone/src/tests/acceptance/features/app-files-sharing.feature:86
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                          # ActorContext::iActAs()
    And I am logged in as "user1"                                             # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "farewell.txt" with "user0"                                   # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    When I share "farewell.txt" with "user1"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jim                                                          # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "user0"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: owner sees reshares with other users                              # /drone/src/tests/acceptance/features/app-files-sharing.feature:113
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "farewell.txt" with "user0"                                   # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    And I share "farewell.txt" with "user1"                                   # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    When I act as John                                                        # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    Then I see that the file is shared with "user0"                           # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I see that the file is shared with "user1"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()

  Scenario: share an empty folder with another user                           # /drone/src/tests/acceptance/features/app-files-sharing.feature:138
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as John                                                         # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "Shared folder" with "user0"                                 # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "Shared folder"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Shared folder"                           # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

  Scenario: sharee sees a folder created by the owner in a shared folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:158
    Given I act as John                                                  # ActorContext::iActAs()
    And I am logged in as the admin                                      # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                    # ActorContext::iActAs()
    And I am logged in                                                   # LoginPageContext::iAmLoggedIn()
    And I act as John                                                    # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                      # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                             # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                       # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I enter in the folder named "Shared folder"                      # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                          # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                   # ActorContext::iActAs()
    And I open the Files app                                             # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                      # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"      # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: owner sees a folder created by the sharee in a shared folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:177
    Given I act as John                                                  # ActorContext::iActAs()
    And I am logged in as the admin                                      # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                    # ActorContext::iActAs()
    And I am logged in                                                   # LoginPageContext::iAmLoggedIn()
    And I act as John                                                    # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                      # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                             # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                       # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                    # ActorContext::iActAs()
    And I open the Files app                                             # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                      # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                          # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                   # ActorContext::iActAs()
    And I enter in the folder named "Shared folder"                      # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"      # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: resharee sees a folder created by the owner in a shared folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:197
    Given I act as John                                                    # ActorContext::iActAs()
    And I am logged in as the admin                                        # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                      # ActorContext::iActAs()
    And I am logged in                                                     # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                       # ActorContext::iActAs()
    And I am logged in as "user1"                                          # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                      # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                        # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"     # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                               # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                         # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                      # ActorContext::iActAs()
    And I open the Files app                                               # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                               # FilesAppSharingContext::iShareWith()
    And I act as John                                                      # ActorContext::iActAs()
    And I enter in the folder named "Shared folder"                        # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                            # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jim                                                      # ActorContext::iActAs()
    And I open the Files app                                               # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                        # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: owner sees a folder created by the resharee in a shared folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:223
    Given I act as John                                                    # ActorContext::iActAs()
    And I am logged in as the admin                                        # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                      # ActorContext::iActAs()
    And I am logged in                                                     # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                       # ActorContext::iActAs()
    And I am logged in as "user1"                                          # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                      # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                        # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"     # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                               # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                         # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                      # ActorContext::iActAs()
    And I open the Files app                                               # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                               # FilesAppSharingContext::iShareWith()
    And I act as Jim                                                       # ActorContext::iActAs()
    And I open the Files app                                               # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                        # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                            # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                     # ActorContext::iActAs()
    And I enter in the folder named "Shared folder"                        # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: sharee can not reshare a folder if the sharer disables it         # /drone/src/tests/acceptance/features/app-files-sharing.feature:249
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I act as John                                                         # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I set the share with "user0" as not reshareable                       # FilesAppSharingContext::iSetTheShareWithAsNotReshareable()
    And I see that "user0" can not reshare the share                          # FilesAppSharingContext::iSeeThatCanNotReshareTheShare()
    When I act as Jane                                                        # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "Shared folder"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Shared folder"                           # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
    And I see that resharing the file is not allowed                          # FilesAppSharingContext::iSeeThatResharingTheFileIsNotAllowed()

  Scenario: sharee can not reshare a subfolder if the sharer disables it for the parent folder # /drone/src/tests/acceptance/features/app-files-sharing.feature:272
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in as the admin                                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                                          # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                          # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                            # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                                   # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                             # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I set the share with "user0" as not reshareable                                        # FilesAppSharingContext::iSetTheShareWithAsNotReshareable()
    And I see that "user0" can not reshare the share                                           # FilesAppSharingContext::iSeeThatCanNotReshareTheShare()
    And I enter in the folder named "Shared folder"                                            # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                                # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                             # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I open the Files app                                                                   # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                            # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                            # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "Subfolder"                                                # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                           # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded                  # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that resharing the file is not allowed                                           # FilesAppSharingContext::iSeeThatResharingTheFileIsNotAllowed()

  Scenario: sharee can not reshare a file with edit permission if the sharer disables it # /drone/src/tests/acceptance/features/app-files-sharing.feature:298
    Given I act as John                                                                  # ActorContext::iActAs()
    And I am logged in as the admin                                                      # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                                    # ActorContext::iActAs()
    And I am logged in                                                                   # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                    # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                                         # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "farewell.txt" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                       # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I set the share with "user0" as not editable                                     # FilesAppSharingContext::iSetTheShareWithAsNotEditable()
    And I see that "user0" can not edit the share                                        # FilesAppSharingContext::iSeeThatCanNotEditTheShare()
    When I act as Jane                                                                   # ActorContext::iActAs()
    And I open the Files app                                                             # FilesAppContext::iOpenTheFilesApp()
    And I share "farewell.txt" with "user1"                                              # FilesAppSharingContext::iShareWith()
    Then I see that the file is shared with "user1"                                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I see that "user1" can not edit the share                                        # FilesAppSharingContext::iSeeThatCanNotEditTheShare()
    And I see that "user1" can not be allowed to edit the share                          # FilesAppSharingContext::iSeeThatCanNotBeAllowedToEditTheShare()

  Scenario: sharee can not reshare a folder with create permission if the sharer disables it # /drone/src/tests/acceptance/features/app-files-sharing.feature:318
    Given I act as John                                                                      # ActorContext::iActAs()
    And I am logged in as the admin                                                          # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                                        # ActorContext::iActAs()
    And I am logged in                                                                       # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                        # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                          # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                                 # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                           # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I set the share with "user0" as not creatable                                        # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                       # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    When I act as Jane                                                                       # ActorContext::iActAs()
    And I open the Files app                                                                 # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                                 # FilesAppSharingContext::iShareWith()
    Then I see that the file is shared with "user1"                                          # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I see that "user1" can not create in the share                                       # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                         # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()

  Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
    Given I act as John                                                                   # ActorContext::iActAs()
    And I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I am logged in                                                                    # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I am logged in as "user1"                                                         # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                                     # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as John                                                                     # ActorContext::iActAs()
    And I set the share with "user0" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                    # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                    # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                       # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                      # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded             # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I set the share with "user1" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    Then I see that "user1" can not create in the share                                   # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                      # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I see that it is not possible to create new files                                 # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()

Show full log

  Scenario: open the menu in a public shared link                   # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:3
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    Then I see that the Share menu is shown                         # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: hide download in a public shared link                   # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:14
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is not shown                # PublicShareContext::iSeeThatTheDownloadButtonIsNotShown()
    And I see that the Share menu button is not shown               # PublicShareContext::iSeeThatTheShareMenuButtonIsNotShown()

  Scenario: show download again in a public shared link             # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
    And I set the download of the shared link as shown              # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsShown()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is shown                    # PublicShareContext::iSeeThatTheDownloadButtonIsShown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    And I see that the Share menu is shown                          # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: open a subfolder in a public shared folder                # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:40
    Given I act as John                                               # ActorContext::iActAs()
    And I am logged in                                                # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I create a new folder named "Shared folder with subfolders"   # FileListContext::iCreateANewFolderNamed()
    And I enter in the folder named "Shared folder with subfolders"   # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                       # FileListContext::iCreateANewFolderNamed()
    And I enter in the folder named "Subfolder"                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subsubfolder"                    # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subsubfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the Files app                                          # FilesAppContext::iOpenTheFilesApp()
    And I share the link for "Shared folder with subfolders"          # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                # ActorContext::iActAs()
    And I visit the shared link I wrote down                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the file list contains a file named "Subfolder"   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I enter in the folder named "Subfolder"                       # FileListContext::iEnterInTheFolderNamed()
    And I see that the file list contains a file named "Subsubfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: creation is not possible by default in a public shared folder # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:60
    Given I act as John                                                   # ActorContext::iActAs()
    And I am logged in                                                    # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I create a new folder named "Shared folder"                       # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Shared folder"                              # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                      # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                    # ActorContext::iActAs()
    And I visit the shared link I wrote down                              # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down       # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the file list is eventually loaded                     # FileListContext::iSeeThatTheFileListIsEventuallyLoaded()
    Then I see that it is not possible to create new files                # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()

  Scenario: create folder in a public editable shared folder        # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:80
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                           # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: owner sees folder created in the public page of an editable shared folder # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:101
    Given I act as John                                                               # ActorContext::iActAs()
    And I am logged in                                                                # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I create a new folder named "Editable shared folder"                          # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                                      # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                         # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"                                 # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                                             # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
    And I act as Jane                                                                 # ActorContext::iActAs()
    And I visit the shared link I wrote down                                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down                   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                                # ActorContext::iActAs()
    And I enter in the folder named "Editable shared folder"                          # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: set a password to a shared link                                                    # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:125
    Given I am logged in                                                                       # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt"                                                     # FilesAppSharingContext::iShareTheLinkFor()
    When I protect the shared link with the password "abcdef"                                  # FilesAppSharingContext::iProtectTheSharedLinkWithThePassword()
    Then I see that the password protect is disabled while loading                             # FilesAppSharingContext::iSeeThatThePasswordProtectIsDisabledWhileLoading()
    And I see that the link share is password protected                                        # FilesAppSharingContext::iSeeThatTheLinkShareIsPasswordProtected()
    And I see that the checkbox to protect the password of the link share by Talk is not shown # FilesAppSharingContext::iSeeThatTheCheckboxToProtectThePasswordOfTheLinkShareByTalkIsNotShown()

  Scenario: access a shared link protected by password with a valid password                   # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:135
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the shared link I wrote down  # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I authenticate with password "abcdef"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the shared link I wrote down                           # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the shared file preview shows the text "Welcome to your Nextcloud account!" # PublicShareContext::iSeeThatTheSharedFilePreviewShowsTheText()

  Scenario: access a shared link protected by password with an invalid password                # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:147
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I authenticate with password "fedcba"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I see that a wrong password for the shared file message is shown                       # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()

  Scenario: access a direct download shared link protected by password with a valid password                  # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:158
    Given I act as John                                                                                       # ActorContext::iActAs()
    And I am logged in                                                                                        # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I share the link for "welcome.txt" protected by the password "abcdef"                                 # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                                          # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                                        # ActorContext::iActAs()
    And I visit the direct download shared link I wrote down                                                  # PublicShareContext::iVisitTheDirectDownloadSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()
    And I authenticate with password "abcdef"                                                                 # PublicShareContext::iAuthenticateWithPassword()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()

acceptance-app-files-tags

tests/acceptance/features/app-files-tags.feature:22

Show full log

  Scenario: create tags using the Administration settings                                    # /drone/src/tests/acceptance/features/app-files-tags.feature:22
    Given I am logged in as the admin                                                        # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I visit the settings page                                                            # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Basic settings" section of the "Administration" group                    # AppNavigationContext::iOpenTheSectionOf()
    And I see that the button to select tags is shown                                        # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown()
    When I create the tag "tag1" in the settings                                             # SettingsContext::iCreateTheTagInTheSettings()
    Then I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()

acceptance-app-theming

tests/acceptance/features/app-theming.feature:4
tests/acceptance/features/app-theming.feature:17

Show full log

  Scenario: changing the color updates the header color                    # /drone/src/tests/acceptance/features/app-theming.feature:4
    Given I am logged in as the admin                                      # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I visit the settings page                                          # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Theming" section                                       # AppNavigationContext::iOpenTheSection()
    And I see that the color selector in the Theming app has loaded        # ThemingAppContext::iSeeThatTheColorSelectorInTheThemingAppHasLoaded()
    And I see that the header color is eventually "#0082C9"                # ThemingAppContext::iSeeThatTheHeaderColorIsEventually()
    When I set the "Color" parameter in the Theming app to "#C9C9C9"       # ThemingAppContext::iSetTheParameterInTheThemingAppTo()
    Then I see that the parameters in the Theming app are eventually saved # ThemingAppContext::iSeeThatTheParametersInTheThemingAppAreEventuallySaved()
    And I see that the header color is eventually "#C9C9C9"                # ThemingAppContext::iSeeThatTheHeaderColorIsEventually()

  Scenario: resetting the color updates the header color                       # /drone/src/tests/acceptance/features/app-theming.feature:17
    Given I am logged in as the admin                                          # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I visit the settings page                                              # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Theming" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the color selector in the Theming app has loaded            # ThemingAppContext::iSeeThatTheColorSelectorInTheThemingAppHasLoaded()
    And I set the "Color" parameter in the Theming app to "#C9C9C9"            # ThemingAppContext::iSetTheParameterInTheThemingAppTo()
    And I see that the parameters in the Theming app are eventually saved      # ThemingAppContext::iSeeThatTheParametersInTheThemingAppAreEventuallySaved()
    And I see that the header color is eventually "#C9C9C9"                    # ThemingAppContext::iSeeThatTheHeaderColorIsEventually()
    When I reset the "Color" parameter in the Theming app to its default value # ThemingAppContext::iSetTheParameterInTheThemingAppToItsDefaultValue()
    Then I see that the parameters in the Theming app are eventually saved     # ThemingAppContext::iSeeThatTheParametersInTheThemingAppAreEventuallySaved()
    And I see that the header color is eventually "#0082C9"                    # ThemingAppContext::iSeeThatTheHeaderColorIsEventually()

acceptance-header

tests/acceptance/features/header.feature:4
tests/acceptance/features/header.feature:15
tests/acceptance/features/header.feature:24
tests/acceptance/features/header.feature:31
tests/acceptance/features/header.feature:42
tests/acceptance/features/header.feature:55
tests/acceptance/features/header.feature:76

Show full log

  Scenario: admin users can see admin-level items in the Settings menu # /drone/src/tests/acceptance/features/header.feature:4
    Given I am logged in as the admin                                  # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I open the Settings menu                                      # SettingsMenuContext::iOpenTheSettingsMenu()
    Then I see that the Settings menu is shown                         # SettingsMenuContext::iSeeThatTheSettingsMenuIsShown()
    And I see that the Settings menu has only 5 items                  # SettingsMenuContext::iSeeThatTheSettingsMenuHasOnlyXItems()
    And I see that the "Settings" item in the Settings menu is shown   # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Apps" item in the Settings menu is shown       # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Users" item in the Settings menu is shown      # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Help" item in the Settings menu is shown       # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Log out" item in the Settings menu is shown    # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()

  Scenario: normal users can see basic items in the Settings menu    # /drone/src/tests/acceptance/features/header.feature:15
    Given I am logged in                                             # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I open the Settings menu                                    # SettingsMenuContext::iOpenTheSettingsMenu()
    Then I see that the Settings menu is shown                       # SettingsMenuContext::iSeeThatTheSettingsMenuIsShown()
    And I see that the Settings menu has only 3 items                # SettingsMenuContext::iSeeThatTheSettingsMenuHasOnlyXItems()
    And I see that the "Settings" item in the Settings menu is shown # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Help" item in the Settings menu is shown     # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()
    And I see that the "Log out" item in the Settings menu is shown  # SettingsMenuContext::iSeeThatTheItemInTheSettingsMenuIsShown()

  Scenario: other users are seen in the contacts menu                    # /drone/src/tests/acceptance/features/header.feature:24
    Given I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I open the Contacts menu                                        # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

  Scenario: just added users are seen in the contacts menu               # /drone/src/tests/acceptance/features/header.feature:42
    Given I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                         # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                      # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                            # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                      # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1             # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I open the Contacts menu                                        # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

  Scenario: search for other users in the contacts menu                              # /drone/src/tests/acceptance/features/header.feature:55
    Given I am logged in as the admin                                                # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                                  # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                                        # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                                  # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1                         # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the Contacts menu                                                     # ContactsMenuContext::iOpenTheContactsMenu()
    And I see that the Contacts menu is shown                                        # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the Contacts menu search input is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuSearchInputIsShown()
    When I search for the user "user0"                                               # ContactsMenuContext::iSearchForTheUser()
    Then I see that the contact "user1" in the Contacts menu is eventually not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsEventuallyNotShown()
    And I see that the contact "user0" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown             # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

  Scenario: search for unknown users in the contacts menu                # /drone/src/tests/acceptance/features/header.feature:76
    Given I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Contacts menu                                         # ContactsMenuContext::iOpenTheContactsMenu()
    And I see that the Contacts menu is shown                            # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the Contacts menu search input is shown               # ContactsMenuContext::iSeeThatTheContactsMenuSearchInputIsShown()
    When I search for the user "unknownuser"                             # ContactsMenuContext::iSearchForTheUser()
    Then I see that the no results message in the Contacts menu is shown # ContactsMenuContext::iSeeThatTheNoResultsMessageInTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
    And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

acceptance-login

tests/acceptance/features/login.feature:4
tests/acceptance/features/login.feature:9
tests/acceptance/features/login.feature:26
tests/acceptance/features/login.feature:32
tests/acceptance/features/login.feature:38
tests/acceptance/features/login.feature:52

Show full log

  Scenario: log in with valid user and password          # /drone/src/tests/acceptance/features/login.feature:4
    Given I visit the Home page                          # FeatureContext::iVisitTheHomePage()
    When I log in with user user0 and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Files app    # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()

  Scenario: try to log in with valid user and invalid password # /drone/src/tests/acceptance/features/login.feature:9
    Given I visit the Home page                                # FeatureContext::iVisitTheHomePage()
    When I log in with user user0 and password 654321          # LoginPageContext::iLogInWithUserAndPassword()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Login page         # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that a wrong password message is shown           # LoginPageContext::iSeeThatAWrongPasswordMessageIsShown()

  Scenario: try to log in with invalid user                    # /drone/src/tests/acceptance/features/login.feature:26
    Given I visit the Home page                                # FeatureContext::iVisitTheHomePage()
    When I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Login page         # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that a wrong password message is shown           # LoginPageContext::iSeeThatAWrongPasswordMessageIsShown()

  Scenario: try to log in as disabled user                      # /drone/src/tests/acceptance/features/login.feature:32
    Given I visit the Home page                                 # FeatureContext::iVisitTheHomePage()
    When I log in with user disabledUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Login page          # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that the disabled user message is shown           # LoginPageContext::iSeeThatTheDisabledUserMessageIsShown()

  Scenario: log in with invalid user once fixed by admin              # /drone/src/tests/acceptance/features/login.feature:38
    Given I act as John                                               # ActorContext::iActAs()
    And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                   # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                         # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user unknownUser with password 123456acb             # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user unknownUser    # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I act as John                                                 # ActorContext::iActAs()
    And I log in with user unknownUser and password 123456acb         # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Files app                 # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()

  Scenario: log out                                    # /drone/src/tests/acceptance/features/login.feature:52
    Given I am logged in                               # LoginPageContext::iAmLoggedIn()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    When I log out                                     # SettingsMenuContext::iLogOut()
    Then I see that the current page is the Login page # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()

acceptance-users

tests/acceptance/features/users.feature:4
tests/acceptance/features/users.feature:13
tests/acceptance/features/users.feature:25
tests/acceptance/features/users.feature:35
tests/acceptance/features/users.feature:47
tests/acceptance/features/users.feature:61
tests/acceptance/features/users.feature:74
tests/acceptance/features/users.feature:88
tests/acceptance/features/users.feature:103
tests/acceptance/features/users.feature:128
tests/acceptance/features/users.feature:151

Show full log

  Scenario: create a new user                                       # /drone/src/tests/acceptance/features/users.feature:4
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                    # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                 # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                       # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    When I create user unknownUser with password 123456acb          # UsersSettingsContext::iCreateUserWithPassword()
    Then I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

  Scenario: create a new user with a custom display name               # /drone/src/tests/acceptance/features/users.feature:13
    Given I am logged in as the admin                                  # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                       # SettingsMenuContext::iOpenTheUserSettings()
    When I click the New user button                                   # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                          # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I set the user name for the new user to "test"                 # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
    And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
    And I set the password for the new user to "123456acb"             # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
    And I create the new user                                          # UsersSettingsContext::iCreateTheNewUser()
    Then I see that the list of users contains the user "test"         # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

  Scenario: delete a user                                                      # /drone/src/tests/acceptance/features/users.feature:25
    Given I act as Jane                                                        # ActorContext::iActAs()
    And I am logged in as the admin                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                               # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user user0                             # UsersSettingsContext::iOpenTheActionsMenuOf()
    And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Delete user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the list of users does not contains the user user0         # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()

  Scenario: disable a user                                                      # /drone/src/tests/acceptance/features/users.feature:35
    Given I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in as the admin                                             # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                                # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0                    # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user user0                              # UsersSettingsContext::iOpenTheActionsMenuOf()
    And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Disable user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the list of users does not contains the user user0          # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
    When I open the "Disabled users" section                                    # AppNavigationContext::iOpenTheSection()
    Then I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

  Scenario: assign user to a group                           # /drone/src/tests/acceptance/features/users.feature:61
    Given I act as Jane                                      # ActorContext::iActAs()
    And I am logged in as the admin                          # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                             # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I toggle the edit mode for the user user0           # UsersSettingsContext::iToggleTheEditModeForUser()
    Then I see that the edit mode is on for user user0       # UsersSettingsContext::iSeeThatTheEditModeIsOn()

  Scenario: create and delete a group                        # /drone/src/tests/acceptance/features/users.feature:74
    Given I act as Jane                                      # ActorContext::iActAs()
    And I am logged in as the admin                          # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                             # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

  Scenario: delete an empty group   # /drone/src/tests/acceptance/features/users.feature:88
    Given I act as Jane             # ActorContext::iActAs()
    And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings    # SettingsMenuContext::iOpenTheUserSettings()

  Scenario: change columns visibility                          # /drone/src/tests/acceptance/features/users.feature:103
    Given I act as Jane                                        # ActorContext::iActAs()
    And I am logged in as the admin                            # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                               # SettingsMenuContext::iOpenTheUserSettings()
    And I open the settings                                    # AppSettingsContext::iOpenTheSettings()
    And I see that the settings are opened                     # AppSettingsContext::iSeeThatTheSettingsAreOpened()
    When I toggle the showLanguages checkbox in the settings   # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Language" column is shown             # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showLastLogin checkbox in the settings   # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Last login" column is shown           # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showStoragePath checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Storage location" column is shown     # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showUserBackend checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "User backend" column is shown         # UsersSettingsContext::iSeeThatTheColumnIsShown()

  Scenario: change password                                         # /drone/src/tests/acceptance/features/users.feature:128
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                                    # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0        # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I toggle the edit mode for the user user0                  # UsersSettingsContext::iToggleTheEditModeForUser()
    Then I see that the edit mode is on for user user0              # UsersSettingsContext::iSeeThatTheEditModeIsOn()
    And I see that the password of user0 is ""                      # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
    When I set the password for user0 to 123456                     # UsersSettingsContext::iSetTheFieldForUserTo()
    And I see that the password cell for user user0 is done loading # UsersSettingsContext::iSeeThatTheCellForUserIsDoneLoading()
    Then I see that the password of user0 is ""                     # UsersSettingsContext::iSeeThatTheFieldOfUserIs()

  Scenario: change user quota                                # /drone/src/tests/acceptance/features/users.feature:151
    Given I act as Jane                                      # ActorContext::iActAs()
    And I am logged in as the admin                          # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the User settings                             # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I toggle the edit mode for the user user0           # UsersSettingsContext::iToggleTheEditModeForUser()
    Then I see that the edit mode is on for user user0       # UsersSettingsContext::iSeeThatTheEditModeIsOn()
    And I see that the user quota of user0 is Unlimited      # UsersSettingsContext::iSeeThatTheuserQuotaIs()

acceptance-apps

tests/acceptance/features/apps.feature:4
tests/acceptance/features/apps.feature:11
tests/acceptance/features/apps.feature:18
tests/acceptance/features/apps.feature:26
tests/acceptance/features/apps.feature:34
tests/acceptance/features/apps.feature:53
tests/acceptance/features/apps.feature:67

Show full log

  Scenario: enable an installed app                       # /drone/src/tests/acceptance/features/apps.feature:4
    Given I act as Jane                                   # ActorContext::iActAs()
    And I am logged in as the admin                       # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management                        # SettingsMenuContext::iOpenTheAppsManagement()
    When I enable the "QA testing" app                    # AppsManagementContext::iEnableTheApp()
    Then I see that the "QA testing" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

  Scenario: disable a installed app                                 # /drone/src/tests/acceptance/features/apps.feature:11
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management                                  # SettingsMenuContext::iOpenTheAppsManagement()
    When I disable the "Update notification" app                    # AppsManagementContext::iDisableTheApp()
    Then I see that the "Update notification" app has been disabled # AppsManagementContext::iSeeThatTheAppHasBeenDisabled()

  Scenario: Browse enabled apps                          # /drone/src/tests/acceptance/features/apps.feature:18
    Given I act as Jane                                  # ActorContext::iActAs()
    And I am logged in as the admin                      # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management                       # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "Active apps" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Active apps" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see that there are only enabled apps           # AppsManagementContext::iSeeThatThereAreOnlyEnabledApps()

  Scenario: Browse disabled apps                           # /drone/src/tests/acceptance/features/apps.feature:26
    Given I act as Jane                                    # ActorContext::iActAs()
    And I am logged in as the admin                        # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management                         # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "Disabled apps" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Disabled apps" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see that there are only disabled apps            # AppsManagementContext::iSeeThatThereAreOnlyDisabledApps()

  Scenario: Browse app bundles                           # /drone/src/tests/acceptance/features/apps.feature:34
    Given I act as Jane                                  # ActorContext::iActAs()
    And I am logged in as the admin                      # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management                       # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "App bundles" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "App bundles" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see the app bundles                            # AppsManagementContext::iSeeTheAppBundles()
    And I see that the "Enterprise bundle" is disabled   # AppsManagementContext::iSeeThatTheIsDisabled()

  Scenario: View app details                  # /drone/src/tests/acceptance/features/apps.feature:53
    Given I act as Jane                       # ActorContext::iActAs()
    And I am logged in as the admin           # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management            # SettingsMenuContext::iOpenTheAppsManagement()
    When I click on the "QA testing" app      # AppsManagementContext::iClickOnTheApp()
    Then I see that the app details are shown # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

  Scenario: Show section from app store               # /drone/src/tests/acceptance/features/apps.feature:67
    Given I act as Jane                               # ActorContext::iActAs()
    And I am logged in as the admin                   # LoginPageContext::iAmLoggedInAsTheAdmin()
      User name field in Login page could not be found after 100 seconds (NoSuchElementException)
    And I open the Apps management                    # SettingsMenuContext::iOpenTheAppsManagement()
    And I see that the current section is "Your apps" # AppNavigationContext::iSeeThatTheCurrentSectionIs()

Signed-off-by: Georg Ehrke <[email protected]>

MorrisJobke

code looks good 👍

skjnldsv · 2020-09-14T06:16:18Z

/backport to stable19

skjnldsv · 2020-09-14T06:16:22Z

/backport to stable18

skjnldsv · 2020-09-14T06:16:32Z

/backport to stable17

csware · 2020-10-12T09:02:56Z

apps/dav/lib/Connector/Sabre/Principal.php

-			$user = $this->userManager->get($name);
+			// Depending on where it is called, it may happen that this function
+			// is called either with a urlencoded version of the name or with a non-urlencoded one.
+			// The urldecode function replaces %## and +, both of which are forbidden in usernames.


This assumption is not correct. For historic reasons there still are usernames containing "+".

=> Discussion at #23315

georgehrke added the 3. to review Waiting for reviews label Sep 10, 2020

georgehrke added this to the Nextcloud 20 milestone Sep 10, 2020

georgehrke requested review from MorrisJobke, nickvergessen and rullzer September 10, 2020 10:59

georgehrke force-pushed the bugfix/noid/urldecode_principal_uri branch from e91618a to fcddf8b Compare September 10, 2020 11:00

rullzer mentioned this pull request Sep 10, 2020

20 beta 4 #22562

Merged

13 tasks

Mitigate encoding issue with user principal uri

b5204a7

Signed-off-by: Georg Ehrke <[email protected]>

georgehrke force-pushed the bugfix/noid/urldecode_principal_uri branch from fcddf8b to b5204a7 Compare September 10, 2020 14:00

MorrisJobke approved these changes Sep 10, 2020

View reviewed changes

MorrisJobke requested a review from ChristophWurst September 10, 2020 14:10

rullzer mentioned this pull request Sep 11, 2020

20 RC1 #22794

Merged

5 tasks

skjnldsv approved these changes Sep 14, 2020

View reviewed changes

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 14, 2020

skjnldsv merged commit 8e22c90 into master Sep 14, 2020

skjnldsv deleted the bugfix/noid/urldecode_principal_uri branch September 14, 2020 06:14

skjnldsv mentioned this pull request Sep 14, 2020

Calendar: Usernames containing whitespace prevent being invitied to event #22741

Closed

backportbot-nextcloud bot added the backport-request label Sep 14, 2020

This was referenced Sep 14, 2020

[stable19] Mitigate encoding issue with user principal uri #22840

Merged

[stable18] Mitigate encoding issue with user principal uri #22841

Merged

backportbot-nextcloud bot removed the backport-request label Sep 14, 2020

backportbot-nextcloud bot mentioned this pull request Sep 14, 2020

[stable17] Mitigate encoding issue with user principal uri #22842

Merged

kesselb mentioned this pull request Oct 9, 2020

404 for user home folder after upgrade from 19.0.3 to >=19.0.4, 20, 21, 22 & 23 #23315

Closed

csware reviewed Oct 12, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Mitigate encoding issue with user principal uri #22770

Mitigate encoding issue with user principal uri #22770

Uh oh!

georgehrke commented Sep 10, 2020

Uh oh!

georgehrke commented Sep 10, 2020

Uh oh!

georgehrke commented Sep 10, 2020

Uh oh!

faily-bot bot commented Sep 10, 2020

Uh oh!

MorrisJobke left a comment

Uh oh!

skjnldsv commented Sep 14, 2020

Uh oh!

skjnldsv commented Sep 14, 2020

Uh oh!

skjnldsv commented Sep 14, 2020

Uh oh!

csware Oct 12, 2020

Uh oh!

nickvergessen Oct 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Mitigate encoding issue with user principal uri #22770

Mitigate encoding issue with user principal uri #22770

Uh oh!

Conversation

georgehrke commented Sep 10, 2020

Uh oh!

georgehrke commented Sep 10, 2020

Uh oh!

georgehrke commented Sep 10, 2020

Uh oh!

faily-bot bot commented Sep 10, 2020

Status of 32951: failure

acceptance-access-levels

acceptance-app-files

acceptance-app-files-sharing

acceptance-app-files-sharing-link

acceptance-app-files-tags

acceptance-app-theming

acceptance-header

acceptance-login

acceptance-users

acceptance-apps

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Sep 14, 2020

Uh oh!

skjnldsv commented Sep 14, 2020

Uh oh!

skjnldsv commented Sep 14, 2020

Uh oh!

csware Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

nickvergessen Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants