Skip to content

[stable18] improve handling of out of space errors for smb #22927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 1, 2020
Merged

[stable18] improve handling of out of space errors for smb #22927

rullzer merged 1 commit into from
Oct 1, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 17, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22915

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.10 milestone Sep 17, 2020
@rullzer
Copy link
Member

rullzer commented Sep 18, 2020

Conflicts... @icewind1991 please have a look

@rullzer rullzer added the 2. developing Work in progress label Sep 18, 2020
@rullzer rullzer mentioned this pull request Sep 28, 2020
Merged
1 task
@icewind1991 icewind1991 force-pushed the backport/22915/stable18 branch from ef07ca7 to 16fc348 Compare September 29, 2020 13:24
@faily-bot
Copy link

faily-bot bot commented Sep 29, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33471: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithGroup with data set #0 ('home::shareOwner', 'files/test.txt', 'files/test2.txt')
Failed asserting that '47' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1014

@icewind1991
Copy link
Member

icewind1991 commented Sep 29, 2020

rebased

@rullzer rullzer merged commit bc63398 into stable18 Oct 1, 2020
@rullzer rullzer deleted the backport/22915/stable18 branch October 1, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

2. developing Work in progress bug feature: external storage

Projects

None yet

Milestone

Nextcloud 18.0.10

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @icewind1991 @juliusknorr