Skip to content

[stable18] Flow: do not hide "matches" and "does not match" checkers #22989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 1, 2020
Merged

[stable18] Flow: do not hide "matches" and "does not match" checkers #22989

rullzer merged 1 commit into from
Oct 1, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 21, 2020 •
edited by nickvergessen
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22533

@backportbot-nextcloud backportbot-nextcloud bot added feature: workflows papercut Annoying recurring UX issue with possibly simple fix. labels Sep 21, 2020
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.10 milestone Sep 21, 2020
@nickvergessen
Copy link
Member

nickvergessen commented Sep 21, 2020

/compile amend /

@rullzer rullzer mentioned this pull request Sep 28, 2020
Merged
1 task
@blizzz @nickvergessen
do not hide "matches" and "does not match" checkers
6137466 
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly

Signed-off-by: Arthur Schiwon <[email protected]>
@nickvergessen nickvergessen force-pushed the backport/22533/stable18 branch from 8aa038c to 6137466 Compare September 29, 2020 07:39
@faily-bot
Copy link

faily-bot bot commented Sep 29, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33460: failure

mysql5.6-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #137 ('folder', 9, 19)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

@rullzer rullzer merged commit 08e96ab into stable18 Oct 1, 2020
@rullzer rullzer deleted the backport/22533/stable18 branch October 1, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

feature: workflows papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 18.0.10

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @rullzer @blizzz