Also check the path based mimetype for flow rule checks #23096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be detemined though the content Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/mimetypes2
branch
from
6b98b9f to
6347968
Compare
juliusknorr
requested review from
ChristophWurst,
kesselb,
nickvergessen and
rullzer
Member
|
@juliushaertl Backport? |
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
Member
|
This one causes the directory checks are not working anymore in the files_accesscontrol app. Because directories are detected as "application/octect-stream" and then a check against "httpd/unix-directory" does not match anymore. Let me check how to fix this. |
MorrisJobke
added a commit
that referenced
this pull request
Nov 30, 2020
… only for non-directories Ref #23096 Signed-off-by: Morris Jobke <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
… only for non-directories Ref #23096 Signed-off-by: Morris Jobke <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
… only for non-directories Ref #23096 Signed-off-by: Morris Jobke <[email protected]>
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR it is not possible to match workflow rules against application/javascript or application/x-ms-dos-executable since they are not part of the mimetypemappings and the detectContents always uses the secure fallback, so checking for those file types for example always fails:
This PR makes sure that when checking for a workflow rule both the detected type on the content and path are checked.