Less psalm warnings

[kesselb]

• Update signature for like/notLike/in/notIn: $x is always passed to quoteColumnName hence ILiteral|IParameter|IQueryFunction are supported.
• Update signature for in/notIn: $y is always passed to quoteColumnName hence ILiteral|IParameter|IQueryFunction are supported.
• Update signature for set: also ILiteral and IQueryFunction are valid values.
• Update signature for setValue: also IParameter is supported.

⚠️ Functional change: setValue now casts $value to string. This was done before much later by doctrine.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33616: failure

mariadb10.4-php7.4

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you

acceptance-users

• tests/acceptance/features/users.feature:4

Show full log

  Scenario: create a new user                                       # /drone/src/tests/acceptance/features/users.feature:4
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                    # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                 # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                       # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    When I create user unknownUser with password 123456acb          # UsersSettingsContext::iCreateUserWithPassword()
    Then I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

[MorrisJobke]

So far looks good 👍

Also neat that it solves 129 errors :)

[nickvergessen]

I think this needs to be done on some other functions too, but well one after the other

[MorrisJobke]

@kesselb the PHPDoc of setValue is updated, right? Anything else missing to get this in?

[kesselb]

@kesselb the PHPDoc of setValue is updated, right? Anything else missing to get this in?

@MorrisJobke ready. Just the check was missing.

[ChristophWurst]

🙏 this also solves some issues in Mail reported by psalm. Thanks 🚀

[MorrisJobke]

I back ported the PHPDoc in #23971, because there was the method newly used and thus caused issues.