Skip to content

Only run the query to get the account data once #23215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 6, 2020
Merged

Only run the query to get the account data once #23215

rullzer merged 1 commit into from
Oct 6, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 6, 2020

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Oct 6, 2020
kesselb
kesselb approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 🚀

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2020

/backport to stable20

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2020

/backport to stable19

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2020

/backport to stable18

@faily-bot
Copy link

faily-bot bot commented Oct 6, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33712: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log 
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@rullzer rullzer merged commit 0c89954 into master Oct 6, 2020
@rullzer rullzer deleted the bugfix/noid/only-run-the-query-once branch October 6, 2020 10:46
This was referenced Oct 6, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @ChristophWurst @kesselb @rullzer