[stable18] Sync all users to the system addresssbook

[nickvergessen]

Backport of #22983

[MorrisJobke]

@rullzer Your call if this should go into 18.0.10 or 18.0.11

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33730: failure

sqlite

Show full log

There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.1-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:730

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Comments\ManagerTest::testDelete
Failed asserting that exception of type "InvalidArgumentException" matches expected exception "OCP\Comments\NotFoundException". Message was: "IDs must be translatable to a number in this implementation." at
/drone/src/lib/private/Comments/Manager.php:246
/drone/src/tests/lib/Comments/ManagerTest.php:456
.

mysql8.0-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #243 ('folder', 31, 21)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

[rullzer]

Lets do it. It is in the other backports anyways