Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 7, 2020

Else we won't find the right translations

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer
Copy link
Member Author

rullzer commented Oct 7, 2020

/backport to stable20

@faily-bot
Copy link

faily-bot bot commented Oct 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33781: failure

integration-sharing-v1-video-verification

  • build/integration/sharing_features/sharing-v1-video-verification.feature:8
Show full log
  Scenario: Creating a link share with send password by Talk # /drone/src/build/integration/sharing_features/sharing-v1-video-verification.feature:8
[Wed Oct  7 09:03:02 2020] TypeError: Argument 2 passed to OC\Comments\Manager::__construct() must implement interface Psr\Log\LoggerInterface, instance of OC\AppFramework\Logger given, called in /drone/src/apps/spreed/lib/Chat/CommentsManager.php on line 46 at /drone/src/lib/private/Comments/Manager.php#67
[Wed Oct  7 09:03:02 2020] 127.0.0.1:50758 [200]: /ocs/v2.php/cloud/users/user0
[Wed Oct  7 09:03:02 2020] TypeError: Argument 2 passed to OC\Comments\Manager::__construct() must implement interface Psr\Log\LoggerInterface, instance of OC\AppFramework\Logger given, called in /drone/src/apps/spreed/lib/Chat/CommentsManager.php on line 46 at /drone/src/lib/private/Comments/Manager.php#67
[Wed Oct  7 09:03:02 2020] 127.0.0.1:50778 [200]: /ocs/v2.php/cloud/users/user0
    Given user "user0" exists                                # SharingContext::assureUserExists()
    And As an "user0"                                        # SharingContext::asAn()
[Wed Oct  7 09:03:02 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Wed Oct  7 09:03:02 2020] 127.0.0.1:50790 [401]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                               # SharingContext::creatingShare()
      | path               | welcome.txt |
      | shareType          | 3           |
      | password           | secret      |
      | sendPasswordByTalk | true        |
    Then the OCS status code should be "100"                 # SharingContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &00000000416b22c6000000001156a7b7 (
          0 => '997'
      ) matches expected '100'.
    And the HTTP status code should be "200"                 # SharingContext::theHTTPStatusCodeShouldBe()
    And last share with password "secret" can be downloaded  # SharingContext::lastShareWithPasswordCanBeDownloaded()

@rullzer rullzer merged commit 67704a9 into master Oct 7, 2020
@rullzer rullzer deleted the fix/l10n/activities branch October 7, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants