Remove bold font-weight and lower font-size for empty search box

[jacobneplokh]

Fixes #22987

Simple changes to the h2 part. Let me know if there is anything wrong, of course :)

Signed-off-by: Jacob Neplokh [email protected]

[jancborchardt]

Hi @jneplokh :) This change would change all h2 styles, and that is a bit much. Could you limit it to only change the h2 of the search emptycontent? As far as I could see, you would simply have to do your changes in this file:
https://github.com/nextcloud/server/blob/master/core/src/views/UnifiedSearch.vue#L745-L748

[jancborchardt]

@ma12-co did you define the new 15px default as a variable? If not, could you do that, so we can use them elsewhere where we need to bring semantically different elements down visually, like in this case?

[jacobneplokh]

This change would change all h2 styles, and that is a bit much.

Ok, yeah, I was not sure if that was changing too much, but opened a PR anyways (as if I am wrong, I would get corrected, like now 😄)

As far as I could see, you would simply have to do your changes in this file:
https://github.com/nextcloud/server/blob/master/core/src/views/UnifiedSearch.vue#L745-L748

Unfortunately, when I added font-weight: normal; and even font-size: 40px; (the latter is just to further test it) on my dev server, the changes were not reflected (while the h2 changes are). I imagine I have to do something in order to reflect the changes?

Also, I was hoping to close #22978 in the same PR as they seem related. Where would the code be to change the status font size and font weight? Or would it be better to open a separate PR?

Thank you!

[jacobneplokh]

Hey, just bumping this! Do you know what I would have to do to reflect the changes on my dev server?

[jancborchardt]

@jneplokh sorry for the late reply! If you do changes to parts like search, you need to compile them with this terminal command: npm ci && MODULE=core npm run build :)

[jacobneplokh]

npm ci && MODULE=core npm run build

Awesome, that worked! Just pushed the commit to fix the issue :)

[skjnldsv]

Hey! What is the status here?

[jacobneplokh]

Hey! What is the status here?

Hello! It seems to be working (on my end), but there was a failed check: https://github.com/nextcloud/server/pull/23267/checks?check_run_id=1316328378

Not sure what is going on there? Do I have to change something here: https://github.com/nextcloud/server/blob/master/core/js/dist/unified-search.js?

[skjnldsv]

Yes, you need to ship the compiled files :)

You can rebase and then use the command /compile /core/js/dist as a github.amrom.workers.devment to have a bot do it for you :)

[jacobneplokh]

/compile /core/js/dist

[jacobneplokh]

Yes, you need to ship the compiled files :)

You can rebase and then use the command /compile /core/js/dist as a github.amrom.workers.devment to have a bot do it for you :)

Ah ok, got it. Just rebased and commented :)

[jacobneplokh]

Hmm now it seems the static code analysis has failed: https://github.com/nextcloud/server/pull/23267/checks?check_run_id=1336555393

with a few different errors it seems.

[skjnldsv]

Hmm now it seems the static code analysis has failed: #23267 (checks)

with a few different errors it seems.

Yes, it fails on master, let's ignore :)

[skjnldsv]

/compile /core/js/dist

Ah, you don't need to use the bot if you already shipped the up-to-date compiled files :)
It seems to pass now! 🚀

[skjnldsv]

Also @jneplokh, as a good habit, when you create PRs that touches design, you can add screenshots so it's easier to review :)

[jacobneplokh]

Also @jneplokh, as a good habit, when you create PRs that touches design, you can add screenshots so it's easier to review :)

Makes sense! Will do here and in the future ;)

Thank you for the help here, too!

[jacobneplokh]

For the requested reviewers here is a screenshot of the changes:

[skjnldsv]

/backport to stable20

[marcoambrosini]

Any particular reason behind lowering the font size in the search box? Shouldn't we keep 15px?

[skjnldsv]

Right, we're now using 15. Let's fix this with #23798