Skip to content

Fix the user remove from group in UI #23269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 8, 2020
Merged

Fix the user remove from group in UI #23269

skjnldsv merged 1 commit into from
Oct 8, 2020

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented Oct 8, 2020

Fix the removal of user from the group in UI.

Signed-off-by: Sujith Haridasan [email protected]

@sharidas sharidas self-assigned this Oct 8, 2020
@sharidas sharidas linked an issue Oct 8, 2020 that may be closed by this pull request
Can't remove group from a user #23237
Closed
@sharidas
Copy link
Contributor Author

sharidas commented Oct 8, 2020

Summary

Removal of user from the group in the UI was not working. This change set helps fix the issue.

Description

The removal of user from the group in the user management page was not happening because axios.delete expects param to be the object key in the config to get the data we are passing, i.e, the group id or gid.

Steps done to test

  1. Create a group Group1
  2. Add user user1 to Group1 in the web UI.
  3. Remove user1 from Group1 from UI. No errors are logged in the console or logfile.
  4. Verify the same with the occ, if the user is removed or not.

@sharidas sharidas added the 2. developing Work in progress label Oct 8, 2020
@sharidasan
Fix the user remove from group in UI
9a286d5 
Fix the removal of user from the group in UI.

Signed-off-by: Sujith Haridasan <[email protected]>
@sharidas sharidas force-pushed the fix-remove-user-from-grp branch from 0177ebe to 9a286d5 Compare October 8, 2020 08:12
@sharidas sharidas added the 3. to review Waiting for reviews label Oct 8, 2020
@sharidas sharidas requested a review from skjnldsv October 8, 2020 09:18
@sharidas sharidas removed the 2. developing Work in progress label Oct 8, 2020
GretaD
GretaD approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2020

/backport to stable20

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2020

/backport to stable19

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2020

/backport to stable18

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2020

/compile amend /

@skjnldsv skjnldsv merged commit d15179f into nextcloud:master Oct 8, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 8, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 8, 2020

The backport to stable19 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2020

Ah, shit, we moved the settings app, I forgot

@skjnldsv skjnldsv mentioned this pull request Oct 8, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 8, 2020

The backport to stable18 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2020

stable19 #23282

@kinimodmeyer kinimodmeyer mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GretaD GretaD GretaD approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

@sharidas sharidas

Labels

3. to review Waiting for reviews bug feature: users and groups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't remove group from a user

4 participants

@sharidas @skjnldsv @GretaD @sharidasan