Skip to content

Fix sidebar updateTabs method #23271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 8, 2020
Merged

Fix sidebar updateTabs method #23271

skjnldsv merged 1 commit into from
Oct 8, 2020

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 8, 2020 •
edited
Loading

Needed for 20! ⚠️
Fix nextcloud/photos#467

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component high regression labels Oct 8, 2020
@skjnldsv skjnldsv self-assigned this Oct 8, 2020
@skjnldsv skjnldsv added this to the Nextcloud 20.0.1 milestone Oct 8, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 8, 2020

/compile amend /

@skjnldsv skjnldsv changed the title improve handling of out of space errors for smb Fix sidebar updateTabs method Oct 8, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 8, 2020

@skjnldsv skjnldsv changed the title improve handling of out of space errors for smb Fix sidebar updateTabs method maintenant

Go home Github, you're drunk!

juliusknorr
juliusknorr reviewed Oct 8, 2020
View reviewed changes
@skjnldsv skjnldsv force-pushed the fix/sidebar-updateTabs branch from db2ec75 to 87e59ea Compare October 8, 2020 09:23
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 8, 2020

/compile amend /

@skjnldsv skjnldsv requested a review from juliusknorr October 8, 2020 09:25
@skjnldsv @npmbuildbot
Fix sidebar updateTabs method
fbf77cb 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@faily-bot
Copy link

faily-bot bot commented Oct 8, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33838: failure

mysql5.6-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log 
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 8, 2020
@skjnldsv skjnldsv merged commit c578b11 into stable20 Oct 8, 2020
@skjnldsv skjnldsv deleted the fix/sidebar-updateTabs branch October 8, 2020 10:26
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 12, 2020

/backport to stable20

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 12, 2020

@MorrisJobke that was on stable20

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 12, 2020

master have it alongside other changes, I backported this only

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 12, 2020

The backport to stable20 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 12, 2020

🙈

@MorrisJobke MorrisJobke mentioned this pull request Oct 15, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component high regression

Projects

None yet

Milestone

Nextcloud 20.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @MorrisJobke @rullzer @juliusknorr