Sort deleted files by most recently deleted first #23286

jancborchardt · 2020-10-08T12:48:07Z

Currently when opening the deleted files, I see the oldest files first, which is strange. People should see the most recently deleted files first.

Disclaimer: Due to there being an error in my local instance which causes it to be impossible to delete files (not sure why, but separate issue) I couldn’t actually test this so I hope this is the correct place. :O

jancborchardt · 2020-10-13T11:27:51Z

More reviews @MorrisJobke @gary-kim @kesselb maybe? :)

gary-kim

Thank you for this. I was just starting to get annoyed of this :)

gary-kim · 2020-10-13T13:02:46Z

/compile amend /

gary-kim

Tests need to be adjusted:

server/apps/files_trashbin/tests/js/filelistSpec.js

Line 132 in e1a0b3f

expect(fileList._sortDirection).toEqual('desc');

Signed-off-by: Jan C. Borchardt <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com> Signed-off-by: Morris Jobke <[email protected]>

MorrisJobke

Code looks good and I fixed the tests 👍

faily-bot · 2020-10-13T17:08:05Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34081: failure

acceptance-users

failure block could not be found - most likely this run got canceled

Show full log

+ tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-users --selenium-server selenium:4444 allow-git-repository-modifications features/users.feature
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 48 installs, 0 updates, 0 removals
  - Installing instaclick/php-webdriver (1.4.7): Downloading (connecting...)
Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (20%)�����������������Downloading (25%)�����������������Downloading (30%)�����������������Downloading (35%)�����������������Downloading (50%)�����������������Downloading (55%)�����������������Downloading (60%)�����������������Downloading (80%)�����������������Downloading (85%)�����������������Downloading (90%)�����������������Downloading (100%)
  - Installing symfony/css-selector (v3.4.45): Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (10%)�����������������Downloading (15%)�����������������Downloading (20%)�����������������Downloading (25%)�����������������Downloading (30%)�����������������Downloading (35%)�����������������Downloading (80%)�����������������Downloading (85%)�����������������Downloading (90%)�����������������Downloading (95%)�����������������Downloading (100%)
  - Installing behat/mink (v1.7.1): Downloading (connecting...)���������������������������Downloading (100%)         ���������
  - Installing behat/mink-selenium2-driver (v1.3.1): Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)    Failed to download behat/mink-selenium2-driver from dist: The "https://codeload.github.com/minkphp/MinkSelenium2Driver/legacy.zip/473a9f3ebe0c134ee1e623ce8a9c852832020288" file could not be downloaded: failed to open stream: Connection timed out
    Now trying to download from source
  - Installing behat/mink-selenium2-driver (v1.3.1): Cloning 473a9f3ebe

                                                                                                                                                   
  [RuntimeException]                                                                                                                               
  Failed to clone https://github.com/minkphp/MinkSelenium2Driver.git via https, ssh protocols, aborting.                                           
                                                                                                                                                   
  - https://github.com/minkphp/MinkSelenium2Driver.git                                                                                             
    Cloning into '/drone/src/tests/acceptance/vendor/behat/mink-selenium2-driver'...                                                               
    fatal: unable to access 'https://github.com/minkphp/MinkSelenium2Driver.git/': Failed to connect to github.com port 443: Connection timed out  
                                                                                                                                                   
  - [email protected]:minkphp/MinkSelenium2Driver.git                                                                                                 
    Cloning into '/drone/src/tests/acceptance/vendor/behat/mink-selenium2-driver'...                                                               
    Host key verification failed.                                                                                                                  
    fatal: Could not read from remote repository.                                                                                                  
                                                                                                                                                   
    Please make sure you have the correct access rights                                                                                            
    and the repository exists.                                                                                                                     
                                                                                                                                                   

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

acceptance-apps

failure block could not be found - most likely this run got canceled

Show full log

+ tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-apps --selenium-server selenium:4444 allow-git-repository-modifications features/apps.feature
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 48 installs, 0 updates, 0 removals
  - Installing instaclick/php-webdriver (1.4.7): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (20%)�����������������Downloading (25%)�����������������Downloading (30%)�����������������Downloading (35%)�����������������Downloading (50%)�����������������Downloading (55%)�����������������Downloading (60%)�����������������Downloading (80%)�����������������Downloading (85%)�����������������Downloading (90%)�����������������Downloading (100%)
  - Installing symfony/css-selector (v3.4.45): Downloading (connecting...)
Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (10%)�����������������Downloading (15%)�����������������Downloading (20%)�����������������Downloading (25%)�����������������Downloading (30%)�����������������Downloading (35%)�����������������Downloading (90%)�����������������Downloading (95%)�����������������Downloading (100%)
  - Installing behat/mink (v1.7.1): Downloading (connecting...)
Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)    Failed to download behat/mink from dist: The "https://codeload.github.com/minkphp/Mink/legacy.zip/e6930b9c74693dff7f4e58577e1b1743399f3ff9" file could not be downloaded: failed to open stream: Connection timed out
    Now trying to download from source
  - Installing behat/mink (v1.7.1): Cloning e6930b9c74

                                                                                                                                    
  [RuntimeException]                                                                                                                
  Failed to clone https://github.com/minkphp/Mink.git via https, ssh protocols, aborting.                                           
                                                                                                                                    
  - https://github.com/minkphp/Mink.git                                                                                             
    Cloning into '/drone/src/tests/acceptance/vendor/behat/mink'...                                                                 
    fatal: unable to access 'https://github.com/minkphp/Mink.git/': Failed to connect to github.com port 443: Connection timed out  
                                                                                                                                    
  - [email protected]:minkphp/Mink.git                                                                                                 
    Cloning into '/drone/src/tests/acceptance/vendor/behat/mink'...                                                                 
    Host key verification failed.                                                                                                   
    fatal: Could not read from remote repository.                                                                                   
                                                                                                                                    
    Please make sure you have the correct access rights                                                                             
    and the repository exists.                                                                                                      
                                                                                                                                    

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

jancborchardt added enhancement help wanted design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Oct 8, 2020

jancborchardt added this to the Nextcloud 21 milestone Oct 8, 2020

jancborchardt requested review from icewind1991 and rullzer October 8, 2020 12:48

rullzer approved these changes Oct 8, 2020

View reviewed changes

jancborchardt requested review from MorrisJobke, gary-kim and kesselb October 13, 2020 11:27

kesselb approved these changes Oct 13, 2020

View reviewed changes

gary-kim approved these changes Oct 13, 2020

View reviewed changes

npmbuildbot-nextcloud bot force-pushed the design/deleted-sorting branch from 1e7f2ef to 5ce6981 Compare October 13, 2020 13:16

gary-kim requested changes Oct 13, 2020

View reviewed changes

Sort deleted files by most recently deleted first

0f2f857

Signed-off-by: Jan C. Borchardt <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com> Signed-off-by: Morris Jobke <[email protected]>

MorrisJobke force-pushed the design/deleted-sorting branch from 5ce6981 to 0f2f857 Compare October 13, 2020 15:30

MorrisJobke approved these changes Oct 13, 2020

View reviewed changes

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 13, 2020

gary-kim approved these changes Oct 13, 2020

View reviewed changes

MorrisJobke merged commit 0c67de3 into master Oct 13, 2020

MorrisJobke deleted the design/deleted-sorting branch October 13, 2020 17:42

nina-py mentioned this pull request Dec 20, 2020

When opening the trashbin it doesn't show the most recently deleted files first. #16412

Closed

Pytal mentioned this pull request Mar 1, 2022

[stable20] Show most recently deleted files first in trash can #31391

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sort deleted files by most recently deleted first #23286

Sort deleted files by most recently deleted first #23286

Uh oh!

jancborchardt commented Oct 8, 2020

Uh oh!

jancborchardt commented Oct 13, 2020

Uh oh!

gary-kim left a comment

Uh oh!

gary-kim commented Oct 13, 2020

Uh oh!

gary-kim left a comment

Uh oh!

MorrisJobke left a comment

Uh oh!

faily-bot bot commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Sort deleted files by most recently deleted first #23286

Sort deleted files by most recently deleted first #23286

Uh oh!

Conversation

jancborchardt commented Oct 8, 2020

Uh oh!

jancborchardt commented Oct 13, 2020

Uh oh!

gary-kim left a comment

Choose a reason for hiding this comment

Uh oh!

gary-kim commented Oct 13, 2020

Uh oh!

gary-kim left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

faily-bot bot commented Oct 13, 2020

Status of 34081: failure

acceptance-users

acceptance-apps

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants