Skip to content

Stop transfer of ownership between same users #23300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Oct 12, 2020
Merged

Stop transfer of ownership between same users #23300

MorrisJobke merged 1 commit into from
Oct 12, 2020

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented Oct 9, 2020 •
edited by kesselb
Loading

Fix #23280

Stop the transfer of ownership between same user.

Signed-off-by: Sujith Haridasan [email protected]

@sharidas sharidas self-assigned this Oct 9, 2020
@sharidas sharidas linked an issue Oct 9, 2020 that may be closed by this pull request
Transfer files from<->to same user results in data loss #23280
Closed
@sharidas
Copy link
Contributor Author

sharidas commented Oct 9, 2020

Summary

Transferring ownership between same users look risky.

Description

Imho, transferring files/folders of same user looks little risky, hence made this change set. Hope this looks ok.

How was it tested?

  1. Create user admin
  2. Execute
➜  nextcloud2 git:(master) ✗ ./occ files:transfer-ownership admin admin
PHP Warning:  Module 'pdo_mysql' already loaded in Unknown on line 0
Kindly check the source and destination users, as they are same.
➜  nextcloud2 git:(master) ✗

@kesselb kesselb added 3. to review Waiting for reviews bug labels Oct 9, 2020
nickvergessen
nickvergessen reviewed Oct 9, 2020
View reviewed changes
@sharidasan
Stop transfer of ownership between same users
08bdc54 
Stop the transfer of ownership between same user.

Signed-off-by: Sujith Haridasan <[email protected]>
@sharidas sharidas force-pushed the transfer-ownership-same-user branch from eeb9061 to 08bdc54 Compare October 12, 2020 04:02
@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Oct 12, 2020
@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 12, 2020
@MorrisJobke MorrisJobke removed the 3. to review Waiting for reviews label Oct 12, 2020
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 12, 2020

Ci failure is fixed in #23391

@MorrisJobke MorrisJobke merged commit deb499d into nextcloud:master Oct 12, 2020
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 12, 2020

/backport to stable20

@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 12, 2020

/backport to stable19

@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 12, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 12, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 12, 2020

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 12, 2020

The backport to stable18 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@solracsf solracsf solracsf approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@sharidas sharidas

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

Transfer files from<->to same user results in data loss

7 participants

@sharidas @MorrisJobke @nickvergessen @ChristophWurst @solracsf @kesselb @sharidasan