Skip to content

Conversation

@ChristophWurst
Copy link
Member

This can potentially catch a few bugs with wrong class strings.

Typed code is good code.

Kind-of follow-up to #23310 but not necessarily related.

@ChristophWurst
Copy link
Member Author

/backport to stable20

@ChristophWurst
Copy link
Member Author

/backport to stable19

@ChristophWurst
Copy link
Member Author

Bildschirmfoto von 2020-10-12 11-30-40

huh, this unveiled the first API errors 🚀 ❤️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2020
@ChristophWurst ChristophWurst force-pushed the enhancement/psalm-typed-bootstrap-registration-context branch from cae71af to ad58771 Compare October 12, 2020 13:16
This can potentially catch a few bugs with wrong class strings.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the enhancement/psalm-typed-bootstrap-registration-context branch from ad58771 to ccfe6a9 Compare October 12, 2020 13:16
@faily-bot
Copy link

faily-bot bot commented Oct 12, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34000: failure

sqlite

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.

/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

mariadb10.1-php7.3

mariadb10.4-php7.4

mysql8.0-php7.4

mysql5.6-php7.3

postgres9-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.

/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

postgres11-php7.4

@ChristophWurst ChristophWurst merged commit d51da57 into master Oct 12, 2020
@ChristophWurst ChristophWurst deleted the enhancement/psalm-typed-bootstrap-registration-context branch October 12, 2020 15:14
@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

@ChristophWurst Psalm is 20+ only anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants