-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add Psalm type for the bootstrap registration context #23371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChristophWurst
merged 1 commit into
master
from
enhancement/psalm-typed-bootstrap-registration-context
Oct 12, 2020
Merged
Add Psalm type for the bootstrap registration context #23371
ChristophWurst
merged 1 commit into
master
from
enhancement/psalm-typed-bootstrap-registration-context
Oct 12, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
Member
Author
MorrisJobke
approved these changes
Oct 12, 2020
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
kesselb
approved these changes
Oct 12, 2020
cae71af to
ad58771
Compare
This can potentially catch a few bugs with wrong class strings. Signed-off-by: Christoph Wurst <[email protected]>
ad58771 to
ccfe6a9
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34000: failuresqliteShow full logmariadb10.1-php7.3
mariadb10.4-php7.4
mysql8.0-php7.4
mysql5.6-php7.3
postgres9-php7.3Show full logpostgres11-php7.4
|
|
The backport to stable19 failed. Please do this backport manually. |
Member
|
@ChristophWurst Psalm is 20+ only anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This can potentially catch a few bugs with wrong class strings.
Typed code is good code.
Kind-of follow-up to #23310 but not necessarily related.