Skip to content

Fix typo 'shared' #23378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Oct 12, 2020
Merged

Fix typo 'shared' #23378

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a1f8fb
Fix typo 'shared'
R0Wi Oct 12, 2020
91d4459
Fix code style
MorrisJobke Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix code style 
Signed-off-by: Morris Jobke <[email protected]>
  • Loading branch information
@MorrisJobke
MorrisJobke committed Oct 12, 2020
commit 91d445909ac4fea3e57b07dbfa0fb8dc6ad5223c
2 changes: 1 addition & 1 deletion tests/lib/AppFramework/Bootstrap/RegistrationContextTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public function testRegisterMiddleware(): void {
]);
}

public function dataProvider_TrueFalse(){
public function dataProvider_TrueFalse() {
Copy link
Contributor

@kesselb kesselb Oct 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is a bit uncommon but might be okay for tests.

Copy link
Member Author

@R0Wi R0Wi Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just the way i name it in my app tests. What would be your suggestion for data provider functions?

Copy link
Member

@ChristophWurst ChristophWurst Oct 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registerServiceData?

Copy link
Contributor

@kesselb kesselb Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any convention how to name data providers right now. I would prefer to not mix snake_case and camelCase but we can also merge this.

return[
[true],
[false]
Expand Down