Skip to content

VersioningTest.php:729 is unreliable and should be disabled #23396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Oct 13, 2020
Merged

VersioningTest.php:729 is unreliable and should be disabled #23396

nickvergessen merged 1 commit into from
Oct 13, 2020

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 12, 2020

One from #22305

This happens sometimes:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 12, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 12, 2020
@MorrisJobke MorrisJobke changed the title VersioningTest:729 is unreliable and should be disabled VersioningTest.php:729 is unreliable and should be disabled Oct 12, 2020
@nickvergessen nickvergessen self-assigned this Oct 12, 2020
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2020
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Oct 12, 2020

/backport to stable20

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Oct 12, 2020

/backport to stable19

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Oct 12, 2020

/backport to stable18

@nickvergessen
Copy link
Member

nickvergessen commented Oct 12, 2020

Let me check something tomorrow

@nickvergessen
Copy link
Member

nickvergessen commented Oct 13, 2020

Lets see if #23400 solves it too

@nickvergessen
Copy link
Member

nickvergessen commented Oct 13, 2020

Didn't work so let's do this.

@nickvergessen nickvergessen merged commit 00bf7eb into master Oct 13, 2020
@nickvergessen nickvergessen deleted the tests/22305/flipping-versioningtest branch October 13, 2020 07:08
This was referenced Oct 13, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@nickvergessen nickvergessen

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @nickvergessen @ChristophWurst @skjnldsv