Skip to content

Conversation

@eppfel
Copy link
Member

@eppfel eppfel commented Nov 26, 2016

The link still redirected to the old #link settings/admin#files_external.

I have searched the repo for other occurrences, but found only core/js/integritycheck-failed-notification.js and I#m not sure, if it has to be changed as well.

@nickvergessen @icewind1991 @MorrisJobke

@mention-bot
Copy link

@eppfel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jmaciasportela, @icewind1991 and @PVince81 to be potential reviewers.

@MorrisJobke
Copy link
Member

Tested and works 👍

cc @nickvergessen @LukasReschke @MariusBluem

@icewind1991
Copy link
Member

👍

@eppfel eppfel added 4. to release Ready to be released and/or waiting for tests to finish and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 27, 2016
@eppfel
Copy link
Member Author

eppfel commented Nov 27, 2016

What's with the codecov?

@nickvergessen nickvergessen merged commit 7e6f829 into master Nov 27, 2016
@nickvergessen nickvergessen deleted the fix-exteranl-storage-redirect branch November 27, 2016 08:02
@nickvergessen
Copy link
Member

Codecov just tells you that the changed lines are not covered by tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants