[stable20] Use own psalm instead of a global one

[backportbot-nextcloud]

backport of #23401

[ChristophWurst]

Psalm failed too hard. Let's try with an updated baseline …

[MorrisJobke]

Psalm failed too hard. Let's try with an updated baseline …

There are still some :/

[ChristophWurst]

There are still some :/

One. And I'm not sure why the check is different locally and on CI …

[ChristophWurst]

Ah so two more errors. But for some reasons the baseline update doesn't capture those …

Can you reproduce the failure locally?

[MorrisJobke]

Can you reproduce the failure locally?

$ composer run psalm
> psalm
Scanning files...
Analyzing files...

                                                                                
ERROR: InvalidNullableReturnType - lib/private/Avatar/Avatar.php:145:13 - The declared return type 'bool|string' for OC\Avatar\Avatar::generateAvatarFromSvg is not nullable, but 'false|null|string' contains null (see https://psalm.dev/144)
	 * @return string|boolean


ERROR: ImplicitToStringCast - lib/private/Avatar/Avatar.php:159:25 - Argument 1 of OC_Image::loadFromData expects string, Imagick provided with a __toString method (see https://psalm.dev/060)
			$image->loadFromData($avatar);


ERROR: NullableReturnStatement - lib/private/Avatar/Avatar.php:160:11 - The declared return type 'bool|string' for OC\Avatar\Avatar::generateAvatarFromSvg is not nullable, but the function returns 'null|string' (see https://psalm.dev/139)
			return $image->data();


ERROR: UndefinedInterfaceMethod - lib/private/Files/Stream/Encryption.php:449:16 - Method OCP\Files\Cache\ICacheEntry::offsetGet does not exist (see https://psalm.dev/181)
				$version = $cacheEntry['encryptedVersion'] + 1;


ERROR: InvalidScalarArgument - lib/private/Files/Stream/Encryption.php:501:59 - Argument 2 of OCP\Encryption\IEncryptionModule::decrypt expects string, int|non-empty-lowercase-string provided (see https://psalm.dev/012)
			$this->cache = $this->encryptionModule->decrypt($data, $position);


------------------------------
5 errors found
------------------------------
15307 other issues found.
You can display them with --show-info=true
------------------------------
Psalm can automatically fix 666 of these issues.
Run Psalm again with 
--alter --issues=InvalidReturnType,InvalidNullableReturnType,MismatchingDocblockReturnType,MismatchingDocblockParamType,MissingParamType --dry-run
to see what it can fix.
------------------------------

Checks took 117.95 seconds and used 1,899.642MB of memory
Psalm was able to infer types for 91.1980% of the codebase
Script psalm handling the psalm event returned with error code 1

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34219: failure

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyDirectory
Failed asserting that false matches expected 'qwerty'.

/drone/src/tests/lib/Files/Storage/Storage.php:556

[ChristophWurst]

**Static code analysis / static-code-analysis (pull_request) ** Failing after 1m — static-code-analysis

How many engineers does it take to make Psalm pass?

[ChristophWurst]

**Static code analysis / static-code-analysis (pull_request) ** Failing after 1m — static-code-analysis

Yo …

[MorrisJobke]

CI is green 👍 🙌

[MorrisJobke]

Administrative only -> merge