Skip to content

[stable20] fixes potential passing of null to getUserGroupIds #23514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 1 commit into from
Oct 19, 2020
Merged

[stable20] fixes potential passing of null to getUserGroupIds #23514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixes potential passing of null to getUserGroupIds 
Signed-off-by: Arthur Schiwon <[email protected]>
  • Loading branch information
@blizzz @backportbot
blizzz authored and backportbot[bot] committed Oct 16, 2020
commit a615e7dcfa71bfe5cf47ac32817a53ec1404f10d
2 changes: 1 addition & 1 deletion lib/private/Share20/DefaultShareProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ public function getSharedWith($userId, $shareType, $node, $limit, $offset) {
$cursor->closeCursor();
} elseif ($shareType === IShare::TYPE_GROUP) {
$user = $this->userManager->get($userId);
$allGroups = $this->groupManager->getUserGroupIds($user);
$allGroups = ($user instanceof IUser) ? $this->groupManager->getUserGroupIds($user) : [];

/** @var Share[] $shares2 */
$shares2 = [];
Expand Down