Skip to content

Fix sharing input placeholder for emails #23627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 23, 2020
Merged

Fix sharing input placeholder for emails #23627

skjnldsv merged 1 commit into from
Oct 23, 2020

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 22, 2020

Because we can always get a user by its email

@skjnldsv skjnldsv self-assigned this Oct 22, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 22, 2020

/compile amend /

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 22, 2020

/backport to stable20

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 22, 2020

/backport to stable19

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 22, 2020

/backport to stable18

@skjnldsv skjnldsv added this to the Nextcloud 21 milestone Oct 22, 2020
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/autocomplete-placeholder-email branch from 2985876 to bd8193c Compare October 22, 2020 10:48
MorrisJobke
MorrisJobke approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jancborchardt
jancborchardt reviewed Oct 22, 2020
View reviewed changes
@skjnldsv skjnldsv force-pushed the fix/autocomplete-placeholder-email branch from bd8193c to f7eec28 Compare October 23, 2020 10:27
@faily-bot
Copy link

faily-bot bot commented Oct 23, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34484: failure

mariadb10.1-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteFromSelfLink
Failed asserting that exception of type "OCP\Share\Exceptions\ShareNotFound" matches expected exception "OC\Share20\Exception\ProviderException". Message was: "There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted." at
/drone/src/lib/private/Share20/DefaultShareProvider.php:763
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1770
.

@MorrisJobke MorrisJobke mentioned this pull request Oct 23, 2020
Closed
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 23, 2020

/compile amend /

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 23, 2020
@skjnldsv @npmbuildbot
Fix sharing input placeholder for emails
f0c47bf 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/autocomplete-placeholder-email branch from f7eec28 to f0c47bf Compare October 23, 2020 11:48
@skjnldsv skjnldsv merged commit 2a154f5 into master Oct 23, 2020
@skjnldsv skjnldsv deleted the fix/autocomplete-placeholder-email branch October 23, 2020 12:40
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 23, 2020
Merged
This was referenced Oct 23, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: sharing

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @MorrisJobke @jancborchardt