-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Bring back the restore share button #23630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MorrisJobke
merged 1 commit into
master
from
bugfix/23240/bring-back-restore-share-button
Oct 22, 2020
Merged
Bring back the restore share button #23630
MorrisJobke
merged 1 commit into
master
from
bugfix/23240/bring-back-restore-share-button
Oct 22, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix disabled default file action to still use an anchor element, as this is used in many other places (and potentially apps). Adjusted anchor style to not look like it's clickable and added extras to make sure everything inside still looks clickable as before. Signed-off-by: Vincent Petry <[email protected]>
Member
Author
|
/backport to stable20 |
Member
|
/backport to stable19 |
Member
|
/backport to stable18 |
MorrisJobke
approved these changes
Oct 22, 2020
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
GretaD
approved these changes
Oct 22, 2020
Member
Author
|
restarted failed/cancelled build |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34466: failuremariadb10.4-php7.4Show full log |
Member
see also #22305 :) |
This was referenced Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).
Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.
Fixes #23240
Note: I was not able to remove the unrelated hand icon from the avatar. This would need another more complex fix related to "when no sidebar, don't display hand on action-share".