Skip to content

Conversation

@PVince81
Copy link
Member

Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).

Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.

Fixes #23240

Note: I was not able to remove the unrelated hand icon from the avatar. This would need another more complex fix related to "when no sidebar, don't display hand on action-share".

Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).

Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 added bug 3. to review Waiting for reviews labels Oct 22, 2020
@PVince81 PVince81 added this to the Nextcloud 21 milestone Oct 22, 2020
@PVince81 PVince81 self-assigned this Oct 22, 2020
@PVince81
Copy link
Member Author

/backport to stable20

@MorrisJobke
Copy link
Member

/backport to stable19

@MorrisJobke
Copy link
Member

/backport to stable18

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@PVince81
Copy link
Member Author

restarted failed/cancelled build

@faily-bot
Copy link

faily-bot bot commented Oct 22, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34466: failure

mariadb10.4-php7.4

Show full log
There was 1 error:

1) Test\Comments\ManagerTest::testDeleteCommentsAtObject
InvalidArgumentException: IDs must be translatable to a number in this implementation.

/drone/src/lib/private/Comments/Manager.php:247
/drone/src/tests/lib/Comments/ManagerTest.php:654

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #10 (OC\Files\Search\SearchBinaryOperator Object (...), array(0, 1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
-    1 => 451
+    0 => '451'
+    1 => '452'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

@MorrisJobke
Copy link
Member

restarted failed/cancelled build

see also #22305 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Restore button in Deleted Shares

4 participants