Use bigint for fileid in filecache_extended

[timm2k]

Users get error

An exception occurred while executing 'INSERT INTO `xx_filecache_extended` (`fileid`, `upload_time`) VALUES(?, ?)' with params [4XY6418251, 160369XYZ0]:\\n\\nSQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'fileid' at row 1\"?

[timm2k]

Before:

MariaDB [nextcloud]> describe oc_filecache_extended;
+---------------+------------------+------+-----+---------+-------+
| Field         | Type             | Null | Key | Default | Extra |
+---------------+------------------+------+-----+---------+-------+
| fileid        | int(10) unsigned | NO   | PRI | NULL    |       |
| metadata_etag | varchar(40)      | YES  |     | NULL    |       |
| creation_time | bigint(20)       | NO   | MUL | 0       |       |
| upload_time   | bigint(20)       | NO   | MUL | 0       |       |
+---------------+------------------+------+-----+---------+-------+
4 rows in set (0.007 sec)

MariaDB [nextcloud]>

After occ db:convert-filecache-bigint:

MariaDB [nextcloud]> describe oc_filecache_extended;
+---------------+---------------------+------+-----+---------+-------+
| Field         | Type                | Null | Key | Default | Extra |
+---------------+---------------------+------+-----+---------+-------+
| fileid        | bigint(20) unsigned | NO   | PRI | NULL    |       |
| metadata_etag | varchar(40)         | YES  |     | NULL    |       |
| creation_time | bigint(20)          | NO   | MUL | 0       |       |
| upload_time   | bigint(20)          | NO   | MUL | 0       |       |
+---------------+---------------------+------+-----+---------+-------+
4 rows in set (0.004 sec)

MariaDB [nextcloud]>

[timm2k]

Please backport to stable releases.

[timm2k]

Forgot adding to checkSetupController.php with first submit.

[rullzer]

Nice catch

[MorrisJobke]

Thanks 👍 Makes sense

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34553: failure

mariadb10.4-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteGroupShareWithUserGroupShares
Failed asserting that an array is empty.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:581

[rullzer]

/backport to stable20

[rullzer]

/backport to stable19

[rullzer]

/backport to stable18