Skip to content

Make sure the function signatures of the backgroundjob match #23701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Oct 26, 2020
Merged

Make sure the function signatures of the backgroundjob match #23701

MorrisJobke merged 1 commit into from
Oct 26, 2020

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 26, 2020

Else PHP says no

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer
Make sure the function signatures of the backgroundjob match
1f2ff18 
Else PHP says no

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Oct 26, 2020
@rullzer rullzer added this to the Nextcloud 21 milestone Oct 26, 2020
MorrisJobke
MorrisJobke approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

blizzz
blizzz approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 26, 2020
@MorrisJobke MorrisJobke merged commit a150f2a into master Oct 26, 2020
@MorrisJobke MorrisJobke deleted the fix/fed/bg_signatures branch October 26, 2020 22:01
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 26, 2020

@rullzer Backport?

@rullzer
Copy link
Member Author

rullzer commented Oct 27, 2020

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @MorrisJobke @nickvergessen @blizzz