Fix default quota display value in user row #23711
Conversation
| if (quota === -3) { | ||
| quota = 'none' |
There was a problem hiding this comment.
| if (quota === -3) { | |
| quota = 'none' | |
| if (quota === -3 || quota === 'none') { | |
| return t('settings', 'Unlimited') |
Merge the two?
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Nice! 🚀
A small comment, good otherwise 😉
|
ah yes, my master was not up to date... sorry little bot... fixing |
When selecting default quota in the dropdown, the actual numeric value or "Unlimited" will be displayed instead of "0 B". This matches whatever is displayed after refreshing the page. In the case where the default quota is unlimited, for which the server returns -3 instead of "none", the frontend now also shows "Unlimited" instead of "0 B". Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/21085/userlist-display-default-quota-value
branch
from
cc45a11 to
66ce56e
Compare
|
@skjnldsv I've simplified even further, mind having a second look ? |
PVince81
deleted the
bugfix/21085/userlist-display-default-quota-value
branch
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
on it... all you need to do is recompile everything |
|
stable20 backport here: #23726 took me a while as I'm often confused at the weird juggling that is happening in the "js/*" folders... |
|
@PVince81 Keep in mind to remove the backport-request label after the backport was opened. In this way we can go over the PRs that still have this label to find pending backports. |
When selecting default quota in the dropdown, the actual numeric value
or "Unlimited" will be displayed instead of "0 B". This matches whatever
is displayed after refreshing the page.
In the case where the default quota is unlimited, for which the server
returns -3 instead of "none", the frontend now also shows "Unlimited"
instead of "0 B".
Fixes #21085