Skip to content

Conversation

@MorrisJobke
Copy link
Member

No description provided.

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Nov 3, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Nov 3, 2020
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 3, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 3, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34965: failure

mariadb10.4-php7.4

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ViewTest::testWatcherEtagCrossStorage
Failed asserting that '6f6a27478a15e37dd9cd6daf01b505a9' is not equal to '6f6a27478a15e37dd9cd6daf01b505a9'.

/drone/src/tests/lib/Files/ViewTest.php:900

acceptance-app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:26
Show full log
  Scenario: show download again in a public shared link             # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
      Share link menu trigger in the details view in Files app could not be found after 20 seconds (NoSuchElementException)
    And I set the download of the shared link as shown              # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsShown()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is shown                    # PublicShareContext::iSeeThatTheDownloadButtonIsShown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    And I see that the Share menu is shown                          # PublicShareContext::iSeeThatTheShareMenuIsShown()

@rullzer rullzer merged commit 7a0ac37 into master Nov 3, 2020
@rullzer rullzer deleted the fix/noid/fix-grid-view-in-systemtags-view branch November 3, 2020 18:43
@MorrisJobke
Copy link
Member Author

/backport to stable20

@MorrisJobke
Copy link
Member Author

/backport to stable19

@MorrisJobke
Copy link
Member Author

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants