Skip to content

Conversation

@nickvergessen
Copy link
Member

As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values. So when the
first value is a literal, plain value or column, instead of doing the
math, it will cast the expression to int and continue with a "0". So when
the second parameter is a function or column, we have to put that as
first parameter.

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Nov 6, 2020
@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Nov 6, 2020
@nickvergessen
Copy link
Member Author

/backport to stable20

As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/oci/fix-greatest-order-for-oracle branch from bd9a661 to 3aaf2fa Compare November 6, 2020 11:13
@faily-bot
Copy link

faily-bot bot commented Nov 6, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35123: failure

mariadb10.4-php7.4

Show full log
There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarSearch
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php:153
/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:677

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobke
Copy link
Member

Psalm has some concerns :(

Signed-off-by: Joas Schilling <[email protected]>
@rullzer rullzer merged commit a5fa960 into master Nov 7, 2020
@rullzer rullzer deleted the bugfix/oci/fix-greatest-order-for-oracle branch November 7, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants