Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors #23929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
rullzer
ChristophWurst
approved these changes
Nov 6, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
I'd even say we can deprecate the other methods and the whole class.
rullzer
approved these changes
Nov 6, 2020
ChristophWurst
added
4. to release
Member
Author
Sure, just starting now as this is a breaking method. After transitioning everything over we can remove it immediately from my pov, as it is private and in legacy since a long time |
juliusknorr
approved these changes
Nov 6, 2020
This was referenced Nov 6, 2020
MorrisJobke
deleted the
techdebt/noid/deprecate-prepare-and-execute-audited-as-they-leak-cursors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]