Skip to content

[stable20] Fix greatest/least order for oracle #23975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 4 commits into from
Nov 9, 2020
Merged

[stable20] Fix greatest/least order for oracle #23975

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d111e88
Fix order of GREATEST for Oracle
nickvergessen Nov 4, 2020
c71cc68
Use Query builder function
nickvergessen Nov 6, 2020
2e3cffc
Make sure Oracle always casts everything in the best way
nickvergessen Nov 6, 2020
b3dfa92
Update parameters
nickvergessen Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Query builder function 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Nov 7, 2020
commit c71cc6824e6902b94fb8117814f32ace74f143d2
2 changes: 1 addition & 1 deletion lib/private/Files/Cache/Propagator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public function commitBatch() {
$storageId = (int)$this->storage->getStorageCache()->getNumericId();

$query->update('filecache')
->set('mtime', $query->createFunction('GREATEST(' . $query->getColumnName('mtime') . ', ' . $query->createParameter('time') . ')'))
->set('mtime', $query->func()->greatest('mtime', $query->createParameter('time')))
->set('etag', $query->expr()->literal(uniqid()))
->where($query->expr()->eq('storage', $query->expr()->literal($storageId, IQueryBuilder::PARAM_INT)))
->andWhere($query->expr()->eq('path_hash', $query->createParameter('hash')));
Expand Down