Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 7, 2020

Fix nextcloud/circles#510

If the backend fail, the search cannot work on an undefined variable.

@skjnldsv skjnldsv added this to the Nextcloud 21 milestone Nov 7, 2020
@skjnldsv skjnldsv self-assigned this Nov 7, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2020

/compile amend /

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2020

/backport to stable20

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2020

/backport to stable19

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/sharing/undefined-in-search branch from d24d818 to 65ac9f8 Compare November 7, 2020 22:45
@rullzer

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/sharing/undefined-in-search branch from 65ac9f8 to 53e56b4 Compare November 9, 2020 11:31
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 9, 2020

Rebased

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2020
@MorrisJobke MorrisJobke merged commit 92ddaea into master Nov 9, 2020
@MorrisJobke MorrisJobke deleted the fix/sharing/undefined-in-search branch November 9, 2020 18:41
@skjnldsv
Copy link
Member Author

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting message "Error creating the share" when sharing a file despite the share is created correctly

4 participants