[stable20] Use query builder instead of OC_DB in OC\Files\* #23998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
icewind1991,
nickvergessen,
rullzer and
skjnldsv
skjnldsv
approved these changes
Nov 9, 2020
| // delete the folder without removing the children | ||
| $query = \OC::$server->getDatabaseConnection()->getQueryBuilder(); | ||
| $query->delete('filecache') | ||
| ->where($query->expr()->eq('fileid', $query->createNamedParameter($oldFolderId))); |
Member
There was a problem hiding this comment.
could it ever be an issue that we don't explicitly specify a type here? because by default it will assume the parameter to be a string
Member
There was a problem hiding this comment.
It might be better to specify it to avoid passing in wrong type, but in that direction it seem to work just fine. Then the DB casts it to whatever type it is.
But I would like to fix this then in master first.
Merged
MorrisJobke
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #23937