Installation goes brrrr #24039
Merged
Installation goes brrrr #24039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
faster-installation
branch
2 times, most recently
from
2005bf1 to
aceeb12
Compare
Signed-off-by: Joas Schilling <[email protected]>
…ons anyway Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
faster-installation
branch
from
aceeb12 to
77713ab
Compare
nickvergessen
added
3. to review
nickvergessen
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
rullzer
nickvergessen
commented
Nov 11, 2020
| } else { | ||
| $ms = new \OC\DB\MigrationService($info['id'], \OC::$server->getDatabaseConnection()); | ||
| $ms->migrate(); | ||
| $ms->migrate('latest', true); |
Member
Author
There was a problem hiding this comment.
When we install, we have no data, so we can skip the before and after migration parts which saves some time
Member
|
Really nice 👍
|
MorrisJobke
approved these changes
Nov 11, 2020
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense, tested and works 👍
juliusknorr
added
4. to release
Member
|
Brrrreaks apps as |
Member
Why don't we have tests for this 🙈 |
Member
|
Because it would fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced installation time by ~50%