Skip to content

Fix sharing tab state not matching resharing admin settings #24042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 5 commits into from
Nov 11, 2020
Merged

Fix sharing tab state not matching resharing admin settings #24042

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9218dfb
Do not show "Can reshare" in the menu if resharing is not allowed
danxuliu Nov 10, 2020
a1d79b2
Disable share input for a received share if resharing is not allowed
danxuliu Nov 10, 2020
22d949d
Add acceptance tests for reshares when resharing is disabled
danxuliu Nov 10, 2020
b6dec0b
Add acceptance tests for reshares by link when resharing is disabled
danxuliu Nov 10, 2020
ee852d7
Add integration tests for default share permissions
danxuliu Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not show "Can reshare" in the menu if resharing is not allowed 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Nov 10, 2020
commit 9218dfb975e5579ed86445293253954c1a16ea91
2 changes: 1 addition & 1 deletion apps/files_sharing/js/dist/files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files_sharing/js/dist/files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions apps/files_sharing/src/components/SharingEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@

<!-- reshare permission -->
<ActionCheckbox
v-if="config.isResharingAllowed"
ref="canReshare"
:checked.sync="canReshare"
:value="permissionsShare"
Expand Down