Skip to content

[stable19] Convert the card resource to a string if necessary #24115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Nov 16, 2020
Merged

[stable19] Convert the card resource to a string if necessary #24115

rullzer merged 1 commit into from
Nov 16, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 13, 2020

backport of #24096

@ChristophWurst @backportbot
Convert the card resource to a string if necessary
a4f6ceb 
Apparently the fetched column can be a string or resource. Hence we have
to catch the resource type and convert it to a string.

Signed-off-by: Christoph Wurst <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.5 milestone Nov 13, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 13, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35503: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\MoveFromCacheTraitTest::testBogusPaths with data set #0 ('/bogus.txt', 'bogus.txt')
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/Files/Cache/CacheTest.php:629

@MichaIng MichaIng mentioned this pull request Nov 15, 2020
Merged
@rullzer rullzer merged commit 20b3025 into stable19 Nov 16, 2020
@rullzer rullzer deleted the backport/24096/stable19 branch November 16, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @skjnldsv @rullzer