Skip to content

[stable18] Fix default internal expiration date #24161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 16 commits into from
Nov 16, 2020
Merged

[stable18] Fix default internal expiration date #24161

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1d0a70e
Use the shorter phpunit syntax for mocked return values in ManagerTest
ChristophWurst Mar 25, 2020
f592384
Fix typos in method names
danxuliu Nov 11, 2020
e9dfa13
Fix typo in variable name
danxuliu Nov 11, 2020
66eb123
Remove extra spaces
danxuliu Nov 12, 2020
4789709
Remove wrong and misleading comment
danxuliu Nov 11, 2020
aaeaed0
Add unit tests to enforce a relaxed default share expiration date
danxuliu Nov 11, 2020
f4f39fc
Fix unit test for verifying enforced expire date too far in the future
danxuliu Nov 11, 2020
eae5fa8
Fix unit test for verifying enforced valid expiration date.
danxuliu Nov 12, 2020
6cf3c29
Fix unit test method name
danxuliu Nov 12, 2020
2f8f06f
Fix unit test for expiration date without date but with default
danxuliu Nov 12, 2020
c138d2d
Add unit test for expiration date with date and with default
danxuliu Nov 12, 2020
713e879
Add explicit time to test date for clarity
danxuliu Nov 12, 2020
bae712b
Fix default internal expiration date
danxuliu Nov 12, 2020
68f67d9
Add unit tests for "validateExpirationDateInternal"
danxuliu Nov 12, 2020
aadd0ab
Reset app configs by deleting the values instead of setting the defaults
danxuliu Nov 12, 2020
47ca9e3
Add integration tests for creating shares with default expiration dates
danxuliu Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos in method names 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Nov 16, 2020
commit f59238444a7df953442ce6687998ace41fd401fc
18 changes: 9 additions & 9 deletions tests/lib/Share20/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ public function testGeneralCheckShareRoot() {
}


public function testvalidateExpirationDateInPast() {
public function testValidateExpirationDateInPast() {
$this->expectException(\OCP\Share\Exceptions\GenericShareException::class);
$this->expectExceptionMessage('Expiration date is in the past');

Expand All @@ -782,7 +782,7 @@ public function testvalidateExpirationDateInPast() {
}


public function testvalidateExpirationDateEnforceButNotSet() {
public function testValidateExpirationDateEnforceButNotSet() {
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('Expiration date is enforced');

Expand All @@ -798,7 +798,7 @@ public function testvalidateExpirationDateEnforceButNotSet() {
self::invokePrivate($this->manager, 'validateExpirationDate', [$share]);
}

public function testvalidateExpirationDateEnforceButNotEnabledAndNotSet() {
public function testValidateExpirationDateEnforceButNotEnabledAndNotSet() {
$share = $this->manager->newShare();
$share->setProviderId('foo')->setId('bar');

Expand All @@ -812,7 +812,7 @@ public function testvalidateExpirationDateEnforceButNotEnabledAndNotSet() {
$this->assertNull($share->getExpirationDate());
}

public function testvalidateExpirationDateEnforceButNotSetNewShare() {
public function testValidateExpirationDateEnforceButNotSetNewShare() {
$share = $this->manager->newShare();

$this->config->method('getAppValue')
Expand All @@ -833,7 +833,7 @@ public function testvalidateExpirationDateEnforceButNotSetNewShare() {
$this->assertEquals($expected, $share->getExpirationDate());
}

public function testvalidateExpirationDateEnforceToFarIntoFuture() {
public function testValidateExpirationDateEnforceTooFarIntoFuture() {
// Expire date in the past
$future = new \DateTime();
$future->add(new \DateInterval('P7D'));
Expand All @@ -857,7 +857,7 @@ public function testvalidateExpirationDateEnforceToFarIntoFuture() {
}
}

public function testvalidateExpirationDateEnforceValid() {
public function testValidateExpirationDateEnforceValid() {
// Expire date in the past
$future = new \DateTime();
$future->add(new \DateInterval('P2D'));
Expand Down Expand Up @@ -886,7 +886,7 @@ public function testvalidateExpirationDateEnforceValid() {
$this->assertEquals($expected, $share->getExpirationDate());
}

public function testvalidateExpirationDateNoDateNoDefaultNull() {
public function testValidateExpirationDateNoDateNoDefaultNull() {
$date = new \DateTime();
$date->add(new \DateInterval('P5D'));

Expand All @@ -907,7 +907,7 @@ public function testvalidateExpirationDateNoDateNoDefaultNull() {
$this->assertEquals($expected, $share->getExpirationDate());
}

public function testvalidateExpirationDateNoDateNoDefault() {
public function testValidateExpirationDateNoDateNoDefault() {
$hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
\OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
$hookListner->expects($this->once())->method('listener')->with($this->callback(function ($data) {
Expand All @@ -922,7 +922,7 @@ public function testvalidateExpirationDateNoDateNoDefault() {
$this->assertNull($share->getExpirationDate());
}

public function testvalidateExpirationDateNoDateDefault() {
public function testValidateExpirationDateNoDateDefault() {
$future = new \DateTime();
$future->add(new \DateInterval('P3D'));
$future->setTime(0,0,0);
Expand Down