Skip to content

Update Version2000Date20190808074233.php #24208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbowen116 wants to merge 1 commit into from
Closed

Update Version2000Date20190808074233.php #24208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/workflowengine/lib/Migration/Version2000Date20190808074233.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ protected function ensureEntityColumns(Table $table) {
$table->addColumn('entity', Types::STRING, [
'notnull' => true,
'length' => 256,
'default' => '',
'default' => ' ',
Copy link
Member

@rullzer rullzer Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not removing this be the proper way to go?

Copy link
Member

@juliusknorr juliusknorr Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blizzz Might know exactly but iirc the entity might be empty for old workflowengine rules from before Nextcloud 18 when migrating.

Copy link
Member

@blizzz blizzz Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 18 we have a repair steps that fills the column. This is done after migration, because the column in question did not exist in 17. Setting the default to \OCA\WorkflowEngine\Entity\File::class would then be the right thing, as this is what the post migration job would do to any column that appears empty. Which would render this part of the post-migration script unnecessary, if I do not oversee anything.

Copy link
Member

@MorrisJobke MorrisJobke Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blizzz Mind to do this change in a PR directly?

]);
}
if (!$table->hasColumn('events')) {
Expand Down