Skip to content

[stable19] Use correct year for generated birthdays events #24262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Nov 20, 2020
Merged

[stable19] Use correct year for generated birthdays events #24262

MorrisJobke merged 1 commit into from
Nov 20, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 20, 2020

backport of #24108

@csware @backportbot
Use correct year for generated birthdays events
75cdfd8 
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.

cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586

Signed-off-by: Sven Strickroth <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.6 milestone Nov 20, 2020
@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Nov 20, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 20, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35775: failure

samba

Show full log 
There was 1 failure:

1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
Actual changes are:
Array
(
    [0] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 1
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [1] => OC\Files\Notify\RenameChange Object
        (
            [targetPath:OC\Files\Notify\RenameChange:private] => renamed.txt
            [type:OC\Files\Notify\Change:private] => 4
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [2] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 2
            [path:OC\Files\Notify\Change:private] => renamed.txt
        )

)

Failed asserting that an array contains OC\Files\Notify\RenameChange Object &00000000686479460000000009b15607 (
    'targetPath' => 'renamed.txt'
    'type' => 4
    'path' => 'newfile.txt'
).

/drone/src/apps/files_external/tests/Storage/SmbTest.php:126

@MorrisJobke MorrisJobke merged commit 32503f3 into stable19 Nov 20, 2020
@MorrisJobke MorrisJobke deleted the backport/24108/stable19 branch November 20, 2020 21:41
This was referenced Dec 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@csware csware csware approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@georgehrke georgehrke Awaiting requested review from georgehrke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 19.0.6

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke @csware