send expected format of cloud id #24361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
skjnldsv
approved these changes
Nov 25, 2020
ChristophWurst
approved these changes
Nov 25, 2020
Member
|
so … backport? |
Member
Author
aye, i blend it with the backports of the mother PR |
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addendum to #24162 and actually fixing the bug (again)…
The first parameter must be for some reason the unsanitized id, because at least one of the many test cases that take these things into account relies on it. Initially I did so and only used $remote as returned by
fixRemoteURL, but needed to revert this for the tests to work (I would rather not break them). It slipped that it breaks thegetDisplayNameFromContactwhich requires an id with sanitized remote portion.My preference would be to smooth it and streamline it everywhere, but since it shall be backported and i wasted too much time on the whole topic, this shall it be for now.