Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Nov 25, 2020

This is a follow up to the screenshots in #24162 (comment)

  • the server path was not displayed
  • when a the cloud id contains a the protocol only this was displayed (not shown there)

What I did now:

  • extend the regex to anticipated the protocol
  • hide protocol (unless unencrypted)
  • show the server path of NC is located in a subdirectory

And the IDE fixed the whitespaces ;)

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 26, 2020
@blizzz blizzz force-pushed the fix/noid/display-remote-sharers-filelist branch from 92b037c to 411bf01 Compare November 26, 2020 11:40
@blizzz blizzz force-pushed the fix/noid/display-remote-sharers-filelist branch from 411bf01 to f3f819b Compare November 26, 2020 11:49
@faily-bot
Copy link

faily-bot bot commented Nov 26, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35983: failure

mariadb10.1-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Comments\ManagerTest::testGetTreeWithLimitAndOffset
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'5'
+'0'

/drone/src/tests/lib/Comments/ManagerTest.php:221

@blizzz blizzz merged commit f8a4e07 into master Nov 26, 2020
@blizzz blizzz deleted the fix/noid/display-remote-sharers-filelist branch November 26, 2020 13:08
@blizzz
Copy link
Member Author

blizzz commented Nov 26, 2020

/backport to stable20

@blizzz
Copy link
Member Author

blizzz commented Nov 26, 2020

/backport to stable19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: federation feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants