Skip to content

Migrate LDAP's install.php to a repair step #24406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Nov 30, 2020
Merged

Migrate LDAP's install.php to a repair step #24406

MorrisJobke merged 1 commit into from
Nov 30, 2020

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 27, 2020

Didn't test because I never reset my dev instance. So let's see if CI catches anything :)

@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Nov 27, 2020
@ChristophWurst ChristophWurst self-assigned this Nov 27, 2020
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 27, 2020

There was 1 failure:

  1. Test\InfoXmlTest::testClasses with data set Add drone.io support #17 ('user_ldap')
    Asserting install-migration "OCA\User_LDAP\Migration\SetDefaultProvider" exists
    Failed asserting that false is true.

/home/runner/work/server/server/tests/lib/InfoXmlTest.php:119

🙄

@ChristophWurst ChristophWurst force-pushed the enhancement/ldap-install-php-to-repair-step branch from 8ef4904 to 0a8ccd5 Compare November 27, 2020 08:07
juliusknorr
juliusknorr approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with settings up a fresh instance and connecting ldap. Config values are properly set

nickvergessen
nickvergessen approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

blizzz
blizzz requested changes Nov 27, 2020
View reviewed changes
@ChristophWurst ChristophWurst force-pushed the enhancement/ldap-install-php-to-repair-step branch from 0a8ccd5 to 334f394 Compare November 27, 2020 14:13
blizzz
blizzz approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works as advertized 🍀

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 27, 2020
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 30, 2020

retriggered CI because there were some issues over the weekend.

@MorrisJobke MorrisJobke merged commit 344eacb into master Nov 30, 2020
@MorrisJobke MorrisJobke deleted the enhancement/ldap-install-php-to-repair-step branch November 30, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

6 participants

@ChristophWurst @MorrisJobke @nickvergessen @blizzz @juliusknorr