Skip to content

[stable19] Fix public calendars shared to circles #24447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Nov 30, 2020
Merged

[stable19] Fix public calendars shared to circles #24447

MorrisJobke merged 2 commits into from
Nov 30, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 30, 2020

backport of #23652

@kesselb @backportbot
Update phpdoc for circleToPrincipal
0436416 
as the QueryException is already catched inside circleToPrincipal.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb @backportbot
A valid user session is required for circles.
23263f9 
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.

Signed-off-by: Daniel Kesselberg <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.6 milestone Nov 30, 2020
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 30, 2020
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 30, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 30, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 36067: failure

mysql8.0-php7.2

Show full log 
There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) Test\Files\Cache\MoveFromCacheTraitTest::testGetById
null does not match expected type "array".

/drone/src/tests/lib/Files/Cache/CacheTest.php:495

@MorrisJobke MorrisJobke merged commit 0cc0d82 into stable19 Nov 30, 2020
@MorrisJobke MorrisJobke deleted the backport/23652/stable19 branch November 30, 2020 10:33
This was referenced Dec 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@rullzer rullzer Awaiting requested review from rullzer

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 19.0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @skjnldsv @kesselb